v17 backport: Fix closed channel panic in Online DDL cutover#13731
Merged
shlomi-noach merged 3 commits intovitessio:release-17.0from Aug 8, 2023
Merged
v17 backport: Fix closed channel panic in Online DDL cutover#13731shlomi-noach merged 3 commits intovitessio:release-17.0from
shlomi-noach merged 3 commits intovitessio:release-17.0from
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
Type: Bug
Backport
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
frouioui
approved these changes
Aug 7, 2023
rohit-nayak-ps
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #13729
For some reason the backport bot did not run.
Description
Closing a channel should be owned by the writer to the channel. This PR fixes a closed channel panic, described in #13728.
Related discussion in
golanggoogle group: https://groups.google.com/g/golang-nuts/c/_Q6FCjWIr18/m/Wb_NlyusRL8J?pli=1Related Issue(s)
#13728
Checklist
Deployment Notes