Skip to content

Backport v16: Replace deprecated github.com/golang/mock with go.uber.org/mock #13512 #13601#13602

Closed
shlomi-noach wants to merge 1 commit intovitessio:release-16.0from
planetscale:backport-16-13512
Closed

Backport v16: Replace deprecated github.com/golang/mock with go.uber.org/mock #13512 #13601#13602
shlomi-noach wants to merge 1 commit intovitessio:release-16.0from
planetscale:backport-16-13512

Conversation

@shlomi-noach
Copy link
Contributor

Description

Manual backport of #13512 into release-16.0

github.com/golang/mock is deprecated, and the repository has been archived. The recommended replacement is go.uber.org/mock.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 25, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 25, 2023
@github-actions github-actions bot added this to the v16.0.3 milestone Jul 25, 2023
@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented Jul 25, 2023

In v16 we seem to have a dependency on github.com/golang/mock/mockgen (tools/tools.go) or which there's no equivalent in go.uber.org/mock.
Closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Build/CI NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants