[release-16.0]: Fix upgrade-downgrade test setup and fix the init_db.sql#13525
Merged
harshit-gangal merged 3 commits intovitessio:release-16.0from Jul 19, 2023
Merged
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
upgrade-downgrade test setup and fix the init_db.sqlupgrade-downgrade test setup and fix the init_db.sql
…sql file for upgrade-downgrade tests to work Signed-off-by: Manan Gupta <manan@planetscale.com>
…rsion Signed-off-by: Manan Gupta <manan@planetscale.com>
frouioui
approved these changes
Jul 19, 2023
harshit-gangal
approved these changes
Jul 19, 2023
Closed
tanjinx
pushed a commit
to slackhq/vitess
that referenced
this pull request
Oct 14, 2024
…db.sql` (vitessio#13525) Signed-off-by: Manan Gupta <manan@planetscale.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the ugprade-downgrade test setup which was installing the incorrect versions of binaries. After fixing this change, the test fails which prompted the change in
init_db.sqlfile.In release-17.0 the super read only work was done and it was turned on. In order to preserve downgrade path we need to fix
init_db.sqlbundled in release-16.0 to turn off super_read_only when it is executed.Related Issue(s)
Checklist
Deployment Notes