Skip to content

Better handling of vreplication setState() failure #13488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shlomi-noach merged 4 commits into from
Jul 16, 2023
Merged

Better handling of vreplication setState() failure #13488

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59f7d53
Better handling of vreplication setState() failure
shlomi-noach Jul 13, 2023
47e183a
also encode in setMessage
shlomi-noach Jul 13, 2023
982e51d
Merge branch 'main' into vreplication-controller-error-log
shlomi-noach Jul 13, 2023
e9abfee
remove UTF8 sanitation
shlomi-noach Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/vt/vttablet/tabletmanager/vreplication/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ func (ct *controller) runBlp(ctx context.Context) (err error) {
if isUnrecoverableError(err) || !ct.lastWorkflowError.ShouldRetry() {
log.Errorf("vreplication stream %d going into error state due to %+v", ct.id, err)
if errSetState := vr.setState(binlogplayer.BlpError, err.Error()); errSetState != nil {
log.Errorf("INTERNAL: unable to setState() in controller. Attempting to set error text: [%v]; setState() error is: %v", err, errSetState)
return err // yes, err and not errSetState.
}
return nil // this will cause vreplicate to quit the workflow
Expand Down