Skip to content

[main] Upgrade the Golang version to go1.20.6#13476

Closed
github-actions[bot] wants to merge 4 commits intomainfrom
upgrade-go-to-1.20.6-on-main
Closed

[main] Upgrade the Golang version to go1.20.6#13476
github-actions[bot] wants to merge 4 commits intomainfrom
upgrade-go-to-1.20.6-on-main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Jul 12, 2023

This Pull Request bumps the Golang version to go1.20.6 and the bootstrap version to 20.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
  • Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
    • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.6

Signed-off-by: GitHub <noreply@github.com>
@github-actions github-actions bot added the Benchmark me Add label to PR to run benchmarks label Jul 12, 2023
@github-actions github-actions bot requested a review from derekperkins as a code owner July 12, 2023 00:30
@github-actions github-actions bot added the Component: General Changes throughout the code base label Jul 12, 2023
@github-actions github-actions bot requested a review from dkhenry as a code owner July 12, 2023 00:30
@github-actions github-actions bot added go Skip CI Skip CI actions from running Type: CI/Build labels Jul 12, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 12, 2023
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Jul 12, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jul 17, 2023
frouioui added 3 commits July 17, 2023 10:21
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui removed the Benchmark me Add label to PR to run benchmarks label Jul 20, 2023
@frouioui
Copy link
Copy Markdown
Member

frouioui commented Aug 2, 2023

Replaced by #13682.

@frouioui frouioui closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base go Skip CI Skip CI actions from running Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant