Skip to content

TestFix: Upgrade Downgrade Testing - Backups - Manual#13408

Merged
frouioui merged 1 commit intovitessio:release-16.0from
planetscale:upgrade-downgrade-fix-16
Jun 29, 2023
Merged

TestFix: Upgrade Downgrade Testing - Backups - Manual#13408
frouioui merged 1 commit intovitessio:release-16.0from
planetscale:upgrade-downgrade-fix-16

Conversation

@GuptaManan100
Copy link
Copy Markdown
Contributor

Description

This PR fixes the test Upgrade Downgrade Testing - Backups - Manual after it was found to be failing in release-16.0.

The fix entails reverting the changes in vttablet-up.sh file in #12791

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Testing Component: General Changes throughout the code base labels Jun 29, 2023
@GuptaManan100 GuptaManan100 requested a review from deepthi as a code owner June 29, 2023 07:11
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 29, 2023
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Jun 29, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v16.0.3 milestone Jun 29, 2023
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 29, 2023
Copy link
Copy Markdown
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always the throttler.

@frouioui frouioui merged commit 7251cb3 into vitessio:release-16.0 Jun 29, 2023
@frouioui frouioui deleted the upgrade-downgrade-fix-16 branch June 29, 2023 12:53
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants