Skip to content

[release-17.0] Prevent resetting replication every time we set replication source (#13377) and Don't run any reparent commands if the host is empty (#13396)#13387

Merged
GuptaManan100 merged 3 commits intorelease-17.0from
backport-13377-to-release-17.0
Jun 28, 2023
Merged

[release-17.0] Prevent resetting replication every time we set replication source (#13377) and Don't run any reparent commands if the host is empty (#13396)#13387
GuptaManan100 merged 3 commits intorelease-17.0from
backport-13377-to-release-17.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Jun 27, 2023

Description

This is a backport of #13377 and #13396.

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot vitess-bot bot added the Backport This is a backport label Jun 27, 2023
@vitess-bot vitess-bot bot requested a review from ajm188 as a code owner June 27, 2023 13:21
@vitess-bot vitess-bot bot requested a review from notfelineit as a code owner June 27, 2023 13:21
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 27, 2023
@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Jun 27, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 28, 2023
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 changed the title [release-17.0] Prevent resetting replication every time we set replication source (#13377) [release-17.0] Backport of (#13377) and (#13396) Jun 28, 2023
@deepthi deepthi changed the title [release-17.0] Backport of (#13377) and (#13396) [release-17.0] Prevent resetting replication every time we set replication source (#13377) and Don't run any reparent commands if the host is empty (#13396) Jun 28, 2023
@GuptaManan100 GuptaManan100 merged commit fddd765 into release-17.0 Jun 28, 2023
@GuptaManan100 GuptaManan100 deleted the backport-13377-to-release-17.0 branch June 28, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants