Skip to content

Release of v17.0.0#13369

Merged
mattlord merged 5 commits intovitessio:release-17.0from
planetscale:release-17.0-create_release-1
Jun 27, 2023
Merged

Release of v17.0.0#13369
mattlord merged 5 commits intovitessio:release-17.0from
planetscale:release-17.0-create_release-1

Conversation

@mattlord
Copy link
Member

Includes the release notes and release commit for the v17.0.0 release. Once this PR is merged, we will be able to tag v17.0.0 on the merge commit.

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord added Component: General Changes throughout the code base Do Not Merge Type: Release labels Jun 23, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 23, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 23, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@mattlord mattlord self-assigned this Jun 23, 2023
@github-actions github-actions bot added this to the v17.0.0 milestone Jun 23, 2023
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the release-17.0-create_release-1 branch from 583c6f5 to 9e1248b Compare June 23, 2023 13:50
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 26, 2023
frouioui added 2 commits June 26, 2023 09:50
…create_release-1

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui requested a review from rohit-nayak-ps as a code owner June 26, 2023 07:53
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We were missing the code-unfreeze which I added by merging release-17.0 and setting the workflow to exit 0 manually.

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord merged commit 70a9466 into vitessio:release-17.0 Jun 27, 2023
@mattlord mattlord deleted the release-17.0-create_release-1 branch June 27, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants