Skip to content

Remove additional unused Dockerfile entries#13344

Closed
dbussink wants to merge 1 commit intovitessio:mainfrom
dbussink:remove-more-legacy-dockerfiles
Closed

Remove additional unused Dockerfile entries#13344
dbussink wants to merge 1 commit intovitessio:mainfrom
dbussink:remove-more-legacy-dockerfiles

Conversation

@dbussink
Copy link
Member

The docker/k8s directory also seems to trace back to when Helm was still a thing. It also doesn't actually have a vtorc container which indicates it's not actually used since vtorc is actually required these days.

From the looks of it, the same applies to docker/mini and that is unused as well.

Related Issue(s)

Found when looking at pending comments for #3553

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

The `docker/k8s` directory also seems to trace back to when Helm was
still a thing. It also doesn't actually have a `vtorc` container which
indicates it's not actually used since `vtorc` is actually required
these days.

From the looks of it, the same applies to `docker/mini` and that is
unused as well.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 18, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 18, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v18.0.0 milestone Jun 18, 2023
@derekperkins
Copy link
Member

The k8s images are very much in use, not sure about docker/mini, I didn't know it even existed

image

https://hub.docker.com/orgs/vitess/insights

@dbussink
Copy link
Member Author

The k8s images are very much in use, not sure about docker/mini, I didn't know it even existed

Ah, I don't have access to those Docker stats.

@dbussink
Copy link
Member Author

Closing this as we do seem to publish docker/k8s (but need to dig more where it comes from and how we tag this, since we build from stable-slim for Debian but I see different base version tags 😕).

@dbussink dbussink closed this Jun 19, 2023
@dbussink dbussink deleted the remove-more-legacy-dockerfiles branch June 19, 2023 07:44
@dbussink
Copy link
Member Author

Opened #13347 for the cleanup TODO that we can fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Build/CI NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Type: CI/Build Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants