Remove additional unused Dockerfile entries#13344
Closed
dbussink wants to merge 1 commit intovitessio:mainfrom
Closed
Remove additional unused Dockerfile entries#13344dbussink wants to merge 1 commit intovitessio:mainfrom
dbussink wants to merge 1 commit intovitessio:mainfrom
Conversation
The `docker/k8s` directory also seems to trace back to when Helm was still a thing. It also doesn't actually have a `vtorc` container which indicates it's not actually used since `vtorc` is actually required these days. From the looks of it, the same applies to `docker/mini` and that is unused as well. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Member
Author
Ah, I don't have access to those Docker stats. |
Member
Author
|
Closing this as we do seem to publish |
Member
Author
|
Opened #13347 for the cleanup TODO that we can fix now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The
docker/k8sdirectory also seems to trace back to when Helm was still a thing. It also doesn't actually have avtorccontainer which indicates it's not actually used sincevtorcis actually required these days.From the looks of it, the same applies to
docker/miniand that is unused as well.Related Issue(s)
Found when looking at pending comments for #3553
Checklist