Skip to content

[release-17.0] Deprecate VTGR (#13301)#13304

Merged
mattlord merged 1 commit intovitessio:release-17.0from
planetscale:backport-13301
Jun 12, 2023
Merged

[release-17.0] Deprecate VTGR (#13301)#13304
mattlord merged 1 commit intovitessio:release-17.0from
planetscale:backport-13301

Conversation

@mattlord
Copy link
Member

Description

This is a backport of #13301.

* Deprecate VTGR

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Update help output in test

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Add vtgr deprecation to summary as well

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Align text across files

Signed-off-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord added Type: Internal Cleanup Backport This is a backport Component: General Changes throughout the code base labels Jun 12, 2023
@mattlord mattlord requested review from ajm188 and deepthi as code owners June 12, 2023 21:57
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 12, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 12, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 12, 2023
@mattlord mattlord added this to the v17.0.0 milestone Jun 12, 2023
@mattlord mattlord merged commit 0542138 into vitessio:release-17.0 Jun 12, 2023
@mattlord mattlord deleted the backport-13301 branch June 12, 2023 22:43
@mattlord mattlord mentioned this pull request Jun 12, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant