Skip to content

Deprecate VTGR #13301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattlord merged 5 commits into from
Jun 12, 2023
Merged

Deprecate VTGR #13301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a1c927
Deprecate VTGR
mattlord Jun 12, 2023
cd9509b
Update help output in test
mattlord Jun 12, 2023
e63473f
Merge remote-tracking branch 'origin/main' into vtgr_deprecation
mattlord Jun 12, 2023
79a2f8d
Add vtgr deprecation to summary as well
mattlord Jun 12, 2023
08b1de4
Align text across files
mattlord Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion changelog/17.0/17.0.0/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
- **[Deprecations and Deletions](#deprecations-and-deletions)**
- [Deprecated Flags](#deprecated-flags)
- [Deprecated Stats](#deprecated-stats)
- [`k8stopo` deprecated](#deprecated-k8stopo)
- [Deprecated `vtgr`](#deprecated-vtgr)
- [Deprecated `k8stopo`](#deprecated-k8stopo)


## <a id="major-changes"/>Major Changes
Expand Down Expand Up @@ -452,6 +453,10 @@ These stats are deprecated in v17.
| `backup_duration_seconds` | `BackupDurationNanoseconds` |
| `restore_duration_seconds` | `RestoreDurationNanoseconds` |

### <a id="deprecated-vtgr"/>Deprecated `vtgr`

The `vtgr` component has been deprecated, also see https://github.com/vitessio/vitess/issues/13300. In Vitess 18 `vtgr` will be removed.

#### <a id="deprecated-k8stopo"/>Deprecated `k8stopo`

The `k8stopo` has been deprecated, also see https://github.com/vitessio/vitess/issues/13298. With Vitess 18 the `k8stopo` will be removed.
Expand Down
7 changes: 6 additions & 1 deletion changelog/17.0/17.0.0/summary.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
- **[Deprecations and Deletions](#deprecations-and-deletions)**
- [Deprecated Flags](#deprecated-flags)
- [Deprecated Stats](#deprecated-stats)
- [Deprecated `vtgr`](#deprecated-vtgr)
- [Deprecated `k8stopo`](#deprecated-k8stopo)


Expand Down Expand Up @@ -451,6 +452,10 @@ These stats are deprecated in v17.
| `backup_duration_seconds` | `BackupDurationNanoseconds` |
| `restore_duration_seconds` | `RestoreDurationNanoseconds` |

### <a id="deprecated-vtgr"/>Deprecated `vtgr`

The `vtgr` component has been deprecated, also see https://github.com/vitessio/vitess/issues/13300. In Vitess 18 `vtgr` will be removed.

#### <a id="deprecated-k8stopo"/>Deprecated `k8stopo`

The `k8stopo` has been deprecated, also see https://github.com/vitessio/vitess/issues/13298. With Vitess 18 the `k8stopo` will be removed.
The `k8stopo` has been deprecated, also see https://github.com/vitessio/vitess/issues/13298. With Vitess 18 the `k8stopo` will be removed.
8 changes: 8 additions & 0 deletions go/cmd/vtgr/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,21 @@ package main

import (
"context"
"fmt"

"github.com/spf13/pflag"

"vitess.io/vitess/go/acl"
"vitess.io/vitess/go/vt/log"
"vitess.io/vitess/go/vt/servenv"
"vitess.io/vitess/go/vt/vtgr"
)

const deprecationMsg = "vtgr is deprecated and will be removed in Vitess 18. We recommend using VTOrc with semi-sync replication instead."

func main() {
fmt.Println(deprecationMsg)

var clustersToWatch []string
servenv.OnParseFor("vtgr", func(fs *pflag.FlagSet) {
fs.StringSliceVar(&clustersToWatch, "clusters_to_watch", nil, `Comma-separated list of keyspaces or keyspace/shards that this instance will monitor and repair. Defaults to all clusters in the topology. Example: "ks1,ks2/-80"`)
Expand All @@ -32,6 +38,8 @@ func main() {
})
servenv.ParseFlags("vtgr")

log.Warning(deprecationMsg)

// openTabletDiscovery will open up a connection to topo server
// and populate the tablets in memory
vtgr := vtgr.OpenTabletDiscovery(context.Background(), nil, clustersToWatch)
Expand Down
1 change: 1 addition & 0 deletions go/flags/endtoend/vtgr.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
vtgr is deprecated and will be removed in Vitess 18. We recommend using VTOrc with semi-sync replication instead.
Usage of vtgr:
--abort_rebootstrap Don't allow vtgr to rebootstrap an existing group.
--alsologtostderr log to standard error as well as files
Expand Down