MoveTables: confirm tables are loaded into vttablet schema engine cache before starting workflow#13293
Closed
rohit-nayak-ps wants to merge 2 commits intovitessio:mainfrom
Closed
Conversation
…alidate that the tablet has the new tables in its schema before we start the workflow Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
4 tasks
Member
|
I don't think we need this, I found the issue with #13178 and fixed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a race between the creation of the schema in MoveTables and the reloading of the schema in vttablet which results in some tables not being visible to the workflow when it starts up. It was surfaced by #13178.
This PR adds an additional check after creating the new tables on the target. It validates that the tablet schema cache has the new tables before starting the workflows.
Related Issue(s)
Checklist