-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Deprecating and removing tablet throttler CLI flags and tests #13246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shlomi-noach
merged 71 commits into
vitessio:main
from
planetscale:throttler-deprecate-flags
Jul 13, 2023
Merged
Changes from 60 commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
920d6ab
Table throttler: --throttler-config-via-topo now defaults to 'true'
shlomi-noach 7c2ed12
add deprecation message
shlomi-noach 018b680
endtoend tests: remove '--enable-lag-throttler' and use 'UpdateThrott…
shlomi-noach 930fb2c
always use vtctldclient
shlomi-noach 2903164
use cluster.VtctldClientProcess
shlomi-noach 681e401
disable --throttler-config-via-topo in old throttler tests
shlomi-noach 5aea00b
Remove --throttler-config-via-topo where used, since it now defaults …
shlomi-noach 7e5b0fb
fix vreplication cluster setup, waiting for throttler config to apply
shlomi-noach 3402fcc
changelog
shlomi-noach 6b02492
extend throttler threshold
shlomi-noach e3b8dd1
a bit more verbose
shlomi-noach 9bd46a2
fixed CLI test
shlomi-noach c6b9a21
remove old '--enable-lag-throttler' flag, introduce '--heartbeat_on_d…
shlomi-noach 4c7a944
Merge branch 'main' into throttler-config-default-enable
shlomi-noach 2979d00
more log info in throttler.Open()
shlomi-noach 0890c75
more logging
shlomi-noach 3c893c5
Merge branch 'throttler-config-default-enable' of github.com:planetsc…
shlomi-noach 3d3f6b2
Revert to --heartbeat_enable
shlomi-noach cd2cc1b
Protect throttler config change application with initMutex
mattlord 7c5b416
More CI testing
mattlord 82b7385
CI testing cont
mattlord 5854273
Yes...
mattlord 5efdc96
Somebody doesn't like force pushes so msg here
mattlord 5a60e39
Increase on-demand heartbeat duration from 10s to 1m
mattlord 34e5dd8
Use only on-demand heartbeats everywhere
mattlord c420c4a
Use same throttler config everywhere
mattlord e03df30
Update all keyspaces and don't fail test on missing JSON keys
mattlord 70570a5
Use constant heartbeats in vrepl e2e tests
mattlord dc7b397
Increase workflow command timeout
mattlord 0fc37df
Don't wait for throttler on non-serving primaries
mattlord a02478d
Merge branch 'main' into throttler-config-default-enable
shlomi-noach 11ca17a
https://github.com/vitessio/vitess/issues/13175 is fixed, therefore r…
shlomi-noach 065fd16
Merge remote-tracking branch 'upstream/main' into throttler-config-de…
shlomi-noach f4d277d
Added ToC
shlomi-noach b7c0419
Merge branch 'main' into throttler-config-default-enable
shlomi-noach 0de6a72
Tweak comment and kick CI
mattlord 261b06a
Treat isOpen as the ready/running signal.
mattlord d9bfece
Re-adjust comment
mattlord d6a9f33
Adjust CheckIsReady() to match OnlineDDL's expectation/usage
mattlord bbbb351
Get rid of log messages from SrvKeyspaceWatcher when no node/key
mattlord 48e71a5
More corrections/tweaks
mattlord 9aef276
Use more convenient/clear new IsRunning function
mattlord fc12e4a
Revert "Use more convenient/clear new IsRunning function"
mattlord ba7aa05
Further fix correct use of IsOpen(), IsRunning(), IsEnabled()
shlomi-noach af0ea43
throttler.throttledApps cannot be nil
shlomi-noach 04a4908
Remove --enable_lag_throttler flag
shlomi-noach b974eec
Deprecate --throttler_config_via_topo
shlomi-noach a085d55
remove throttler mitigation code, as the problem was solved in https:…
shlomi-noach 0f5f4d1
deperecate throttler config flags
shlomi-noach a7fea0c
Removed tabletmanager_throttler and tabletmanager_throttler_custom_co…
shlomi-noach ba7e3c6
resolved conflict
shlomi-noach 5893434
changelog
shlomi-noach fafed16
remove EnableThrottler() call
shlomi-noach f29a548
restore default value
shlomi-noach f478e6c
update threshold
shlomi-noach 96f2572
resolved conflict
shlomi-noach 6f3a057
update flags desc
shlomi-noach 37d445a
resolved conflict
shlomi-noach 1db2301
resolved conflict
shlomi-noach 29847bb
resolved conflict
shlomi-noach ce6b94c
using atomic.Bool
shlomi-noach 3fb71de
Update changelog/18.0/18.0.0/summary.md
shlomi-noach d460cdc
Merge branch 'throttler-deprecate-flags' of github.com:planetscale/vi…
shlomi-noach bc9027e
use MarkDeprecated
shlomi-noach 1fc2595
resolved conflict
shlomi-noach 01324bb
do not expect flags in vttablet --help
shlomi-noach 391f20f
remove --throttler-config-via-topo from examples scripts
shlomi-noach 15b6a28
resolved conflict
shlomi-noach c3bfcb2
Merge branch 'main' into throttler-deprecate-flags
shlomi-noach 8260ce4
resolved conflict
shlomi-noach acde739
resolved conflict
shlomi-noach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
139 changes: 0 additions & 139 deletions
139
.github/workflows/cluster_endtoend_tabletmanager_throttler.yml
This file was deleted.
Oops, something went wrong.
139 changes: 0 additions & 139 deletions
139
.github/workflows/cluster_endtoend_tabletmanager_throttler_custom_config.yml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.