VTGate StreamExecute rpc to return session as response#13131
Merged
harshit-gangal merged 8 commits intovitessio:mainfrom May 30, 2023
Merged
VTGate StreamExecute rpc to return session as response#13131harshit-gangal merged 8 commits intovitessio:mainfrom
harshit-gangal merged 8 commits intovitessio:mainfrom
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
| @@ -144,7 +144,11 @@ func (sn *VTGateSession) StreamExecute(ctx context.Context, query string, bindVa | |||
| // StreamExecute is only used for SELECT queries that don't change | |||
Member
Author
There was a problem hiding this comment.
// StreamExecute is only used for SELECT queries that don't change
// the session. So, the protocol doesn't return an updated session.
// This may change in the future.
For sure it has changed and this is the future :)
…on StreamExecute Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
d0b40fa to
5203b73
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
reviewed
May 29, 2023
systay
reviewed
May 29, 2023
systay
reviewed
May 29, 2023
systay
reviewed
May 29, 2023
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
42 tasks
frouioui
approved these changes
May 30, 2023
4 tasks
mattrobenolt
added a commit
to planetscale/psdbproxy
that referenced
this pull request
Jan 29, 2024
…15) This is to accommodate the breaking API change from: vitessio/vitess#13131 Currently PlanetScale explicitly ignores these results so it doesn't break clients, so this is pre-emptively support the new rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with StreamExecute VTGate RPC response. It adds the VTGate Session to the response.
This fixes all the side effects caused by not returning the modified session.
The Session is sent as the last message on the stream after all the Query Results are sent. So, the last stream message will have QueryResult as nil and Session as not nil.
Any error that happened during the query phase will be sent only after sending the Session.
Note: This is not an issue if MySQL clients are used to connect to VTGate.
Related Issue(s)
Checklist
Deployment Notes