Skip to content

gen4 planner bugfix: issue when merging subqueries #13025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
systay merged 1 commit into from
May 5, 2023
Merged

gen4 planner bugfix: issue when merging subqueries #13025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/merging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func (jm *joinMerger) mergeTables(r1, r2 *ShardedRouting, op1, op2 *Route) (*Rou
VindexPreds: append(r1.VindexPreds, r2.VindexPreds...),
keyspace: r1.keyspace,
RouteOpCode: r1.RouteOpCode,
SeenPredicates: r1.SeenPredicates,
SeenPredicates: append(r1.SeenPredicates, r2.SeenPredicates...),
}
if r1.SelectedVindex() == r2.SelectedVindex() {
tr.Selected = r1.Selected
Expand Down
38 changes: 38 additions & 0 deletions go/vt/vtgate/planbuilder/testdata/select_cases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7943,5 +7943,43 @@
"user.user"
]
}
},
{
"comment": "merge subquery using MAX and join into single route",
"query": "select 1 from user join music_extra on user.id = music_extra.user_id where music_extra.music_id = (select max(music_id) from music_extra where user_id = user.id)",
"v3-plan": {
"QueryType": "SELECT",
"Original": "select 1 from user join music_extra on user.id = music_extra.user_id where music_extra.music_id = (select max(music_id) from music_extra where user_id = user.id)",
"Instructions": {
"OperatorType": "Route",
"Variant": "Scatter",
"Keyspace": {
"Name": "user",
"Sharded": true
},
"FieldQuery": "select 1 from `user` join music_extra on `user`.id = music_extra.user_id where 1 != 1",
"Query": "select 1 from `user` join music_extra on `user`.id = music_extra.user_id where music_extra.music_id = (select max(music_id) from music_extra where user_id = `user`.id)",
"Table": "`user`, music_extra"
}
},
"gen4-plan": {
"QueryType": "SELECT",
"Original": "select 1 from user join music_extra on user.id = music_extra.user_id where music_extra.music_id = (select max(music_id) from music_extra where user_id = user.id)",
"Instructions": {
"OperatorType": "Route",
"Variant": "Scatter",
"Keyspace": {
"Name": "user",
"Sharded": true
},
"FieldQuery": "select 1 from `user`, music_extra where 1 != 1",
"Query": "select 1 from `user`, music_extra where music_extra.music_id = (select max(music_id) from music_extra where user_id = `user`.id) and `user`.id = music_extra.user_id",
"Table": "`user`, music_extra"
},
"TablesUsed": [
"user.music_extra",
"user.user"
]
}
}
]