coverage: Remove sonar coverage setup#13000
Merged
dbussink merged 1 commit intovitessio:mainfrom May 1, 2023
Merged
Conversation
Looks like this never was really enabled properly and it's not working at the moment. We never run these jobs on branches and the badge for sonarcloud is broken as well. Let's remove this for now. If we want coverage back, we need to redo it anyway and newer Go releases like Go 1.20 have better support for doing coverage anyway so we'd need to do it differently regardless. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
rohit-nayak-ps
approved these changes
May 1, 2023
mattlord
approved these changes
May 1, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like this never was really enabled properly and it's not working at the moment. We never run these jobs on branches and the badge for sonarcloud is broken as well.
Let's remove this for now. If we want coverage back, we need to redo it anyway and newer Go releases like Go 1.20 have better support for doing coverage anyway so we'd need to do it differently regardless.
Checklist