Skip to content

coverage: Remove sonar coverage setup#13000

Merged
dbussink merged 1 commit intovitessio:mainfrom
planetscale:dbussink/cleanup-unused-sonarcloud
May 1, 2023
Merged

coverage: Remove sonar coverage setup#13000
dbussink merged 1 commit intovitessio:mainfrom
planetscale:dbussink/cleanup-unused-sonarcloud

Conversation

@dbussink
Copy link
Member

@dbussink dbussink commented May 1, 2023

Looks like this never was really enabled properly and it's not working at the moment. We never run these jobs on branches and the badge for sonarcloud is broken as well.

Let's remove this for now. If we want coverage back, we need to redo it anyway and newer Go releases like Go 1.20 have better support for doing coverage anyway so we'd need to do it differently regardless.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Looks like this never was really enabled properly and it's not working
at the moment. We never run these jobs on branches and the badge for
sonarcloud is broken as well.

Let's remove this for now. If we want coverage back, we need to redo it
anyway and newer Go releases like Go 1.20 have better support for doing
coverage anyway so we'd need to do it differently regardless.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink added Type: Internal Cleanup Component: General Changes throughout the code base labels May 1, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels May 1, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 1, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone May 1, 2023
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels May 1, 2023
@dbussink dbussink merged commit 3e9f4c7 into vitessio:main May 1, 2023
@dbussink dbussink deleted the dbussink/cleanup-unused-sonarcloud branch May 1, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants