Skip to content

[Gen4] Aggregation and Grouping on Operators#12994

Merged
harshit-gangal merged 64 commits intovitessio:mainfrom
planetscale:aggr-op
May 25, 2023
Merged

[Gen4] Aggregation and Grouping on Operators#12994
harshit-gangal merged 64 commits intovitessio:mainfrom
planetscale:aggr-op

Conversation

@harshit-gangal
Copy link
Copy Markdown
Member

@harshit-gangal harshit-gangal commented Apr 28, 2023 •
edited
Loading

Description

This PR moves the horizon planning (aggregations, group by, order by) to the new operators model.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 28, 2023
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Apr 28, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@harshit-gangal harshit-gangal added Skip CI Skip CI actions from running and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 28, 2023
@github-actions github-actions bot added this to the v17.0.0 milestone Apr 28, 2023
@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Apr 28, 2023
@harshit-gangal harshit-gangal mentioned this pull request Apr 28, 2023
Closed
14 tasks
harshit-gangal
harshit-gangal commented May 2, 2023
View reviewed changes
harshit-gangal
harshit-gangal commented May 2, 2023
View reviewed changes
@harshit-gangal harshit-gangal force-pushed the aggr-op branch 2 times, most recently from 62a27d4 to 9618467 Compare May 4, 2023 07:59
@harshit-gangal harshit-gangal force-pushed the aggr-op branch 2 times, most recently from f5e59b9 to b8ace21 Compare May 4, 2023 10:39
@systay systay force-pushed the aggr-op branch 5 times, most recently from 789c9ec to 201ffb0 Compare May 8, 2023 06:20
@harshit-gangal harshit-gangal force-pushed the aggr-op branch 2 times, most recently from 61a3e7e to f16e3ca Compare May 12, 2023 05:20
@harshit-gangal
added EnableGeneralLog method to enable general logs on all the mysql…
282ab7f 
… instance, to be used for debugging

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
print vitess plan when vitess and mysql result does not match
ce8b7ef 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
harshit-gangal commented May 22, 2023
View reviewed changes
systay and others added 2 commits May 22, 2023 14:05
@systay
add ORDER BY code to the fuzzer
8bb3370 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
add group by order by test
c97c627 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
harshit-gangal commented May 22, 2023
View reviewed changes
@harshit-gangal
do not pass 0 to rand.Intn func as it causes panic
06475db 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
some code refactor and comments
82b0175 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review May 22, 2023 16:19
GuptaManan100
GuptaManan100 reviewed May 24, 2023
View reviewed changes
systay added 3 commits May 24, 2023 13:21
@systay
added comments
97eff7d 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
added more comments
566a796 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
refactor and comment after review
3c1b92c 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
add column names to projections
fd62d66 
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
harshit-gangal commented May 25, 2023
View reviewed changes
go/vt/vtgate/planbuilder/operator_transformers.go
var primitive *engine.Projection
columnNames := slices2.Map(op.Columns, func(from *sqlparser.AliasedExpr) string {
return from.As.String()
return from.ColumnName()
Copy link
Copy Markdown
Member Author

@harshit-gangal harshit-gangal May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add an e2e test to validate field names are received.

harshit-gangal
harshit-gangal commented May 25, 2023
View reviewed changes
go/vt/vtgate/planbuilder/testdata/aggr_cases.json
Comment on lines +3327 to 3330
"[COLUMN 2] as a",
"[COLUMN 0] * [COLUMN 1] as count(*)",
"[COLUMN 3]"
"[COLUMN 3] as weight_string(`user`.a)"
],
Copy link
Copy Markdown
Member Author

@harshit-gangal harshit-gangal May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the test having projection have column alias. Let's add a test for that.

@harshit-gangal
Merge remote-tracking branch 'upstream/main' into aggr-op
41235db 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit bedcf51 into vitessio:main May 25, 2023
@harshit-gangal harshit-gangal deleted the aggr-op branch May 25, 2023 16:43
@systay systay mentioned this pull request May 29, 2023
Merged
4 tasks
@frouioui frouioui mentioned this pull request Feb 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@systay systay systay approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@deepthi deepthi Awaiting requested review from deepthi

+1 more reviewer

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@systay systay

@harshit-gangal harshit-gangal

Labels

Benchmark me Add label to PR to run benchmarks Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Milestone

v17.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@harshit-gangal @systay @GuptaManan100