tools: Cleanup more unused code#12991
Merged
dbussink merged 1 commit intovitessio:mainfrom Apr 28, 2023
Merged
Conversation
This removes `tools/statsd.go` which seems entirely unused. It also removes a number of dependencies from `tools/tools.go` that we don't use anymore. This is mainly around linting where we use `golangci-lint` now and not these separate ones anymore. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
mattlord
approved these changes
Apr 27, 2023
rohit-nayak-ps
approved these changes
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
tools/statsd.gowhich seems entirely unused. It also removes a number of dependencies fromtools/tools.gothat we don't use anymore.This is mainly around linting where we use
golangci-lintnow and not these separate ones anymore.Found when working on #12987 where I audited all default mux usages.
Checklist