Skip to content

Backport: [topo] Disallow the slash character in shard names #12843#12858

Merged
deepthi merged 3 commits intovitessio:release-16.0from
planetscale:andrew/bp-12843
Apr 12, 2023
Merged

Backport: [topo] Disallow the slash character in shard names #12843#12858
deepthi merged 3 commits intovitessio:release-16.0from
planetscale:andrew/bp-12843

Conversation

@ajm188
Copy link
Copy Markdown
Contributor

@ajm188 ajm188 commented Apr 6, 2023

Backport of #12843

Andrew Mason and others added 2 commits April 6, 2023 17:04
@deepthi
[topo] Disallow the slash character in shard names (vitessio#12843)
26cf001 
* Disallow the slash character in shard names

Fixes vitessio#12842.

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* add release note

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Update go/vt/topo/shard.go

Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
Signed-off-by: Andrew Mason <amason@hey.com>

* Update changelog/17.0/17.0.0/summary.md

Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
Signed-off-by: Andrew Mason <amason@hey.com>

---------

Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <amason@hey.com>
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
add changelog stub
15a4ff5 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188 ajm188 added this to the v16.0.2 milestone Apr 6, 2023
@ajm188 ajm188 requested a review from frouioui April 6, 2023 21:10
@vitess-bot vitess-bot bot added the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Apr 6, 2023
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Apr 6, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added the NeedsWebsiteDocsUpdate What it says label Apr 6, 2023
mattlord
mattlord approved these changes Apr 6, 2023
View reviewed changes
changelog/16.0/16.0.2/summary.md Outdated

### Shard name validation in TopoServer

Prior to v16.0.1, it was possible to create a shard name with invalid characters, which would then be inaccessible to various cluster management operations.
Copy link
Copy Markdown
Member

@mattlord mattlord Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 16.0.2?

Copy link
Copy Markdown
Contributor Author

@ajm188 ajm188 Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, i was so careful to change it from 17!!!

fix version name
6d6310b 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
@frouioui frouioui mentioned this pull request Apr 12, 2023
Closed
21 tasks
@frouioui frouioui added the Release Blocker: release-19.0 This item blocks the release on branch release-19.0 label Apr 12, 2023
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 12, 2023
@deepthi deepthi merged commit 9dcbd7d into vitessio:release-16.0 Apr 12, 2023
@deepthi deepthi deleted the andrew/bp-12843 branch April 12, 2023 22:33
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattlord mattlord mattlord approved these changes

@frouioui frouioui frouioui approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@rsajwani rsajwani Awaiting requested review from rsajwani rsajwani is a code owner

Assignees

No one assigned

Labels

Backport This is a backport Component: Cluster management Release Blocker: release-19.0 This item blocks the release on branch release-19.0 Type: Bug

Projects

None yet

Milestone

v16.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ajm188 @mattlord @frouioui @deepthi