evalengine: Improve the timezone parsing logic#12827
Merged
dbussink merged 2 commits intovitessio:mainfrom Apr 5, 2023
Merged
Conversation
dbussink
requested review from
GuptaManan100,
frouioui,
harshit-gangal,
mattlord and
systay
as code owners
vitess-bot
bot
added
NeedsDescriptionUpdate
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
vmg
approved these changes
Apr 4, 2023
dbussink
force-pushed
the
dbussink/improve-timezone-parsing
branch
from
e68d460 to
5baa27a
Compare
dbussink
added
Type: Enhancement
systay
reviewed
Apr 5, 2023
go/mysql/datetime/time_zone.go
Outdated
systay
reviewed
Apr 5, 2023
go/mysql/datetime/time_zone_test.go
Outdated
systay
approved these changes
Apr 5, 2023
While looking at supporting `CONVERT_TZ` in the evalengine, it was clear that our current timezone parsing didn't suffice. MySQL also supports direct UTC offsets to be used as a timezone identifier which `time.LoadLocation` doesn't handle. This adds support for parsing this style of timezone offsets and a bunch of tests for this as well. It adds a separate parsing function with error so in the future we can use that in `CONVERT_TZ` which returns `NULL` on invalid timezone definitions. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
force-pushed
the
dbussink/improve-timezone-parsing
branch
from
5baa27a to
a6ddc1f
Compare
frouioui
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at supporting
CONVERT_TZin the evalengine, it was clear that our current timezone parsing didn't suffice. MySQL also supports direct UTC offsets to be used as a timezone identifier whichtime.LoadLocationdoesn't handle.This adds support for parsing this style of timezone offsets and a bunch of tests for this as well. It adds a separate parsing function with error so in the future we can use that in
CONVERT_TZwhich returnsNULLon invalid timezone definitions.Related Issue(s)
Part of implementing #9647 and something that was missed in #12742
Checklist