Fix fullstatus test for backward compat#12685
Merged
mattlord merged 1 commit intovitessio:mainfrom Mar 24, 2023
Merged
Conversation
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
rsajwani
changed the title
rsajwani
added
Backport to: release-16.0
Type: Bug
Type: Testing
Component: General
rsajwani
commented
Mar 22, 2023
| require.NoError(t, err) | ||
| primaryStatus := &replicationdatapb.FullStatus{} | ||
| err = protojson.Unmarshal([]byte(primaryStatusString), primaryStatus) | ||
| opt := protojson.UnmarshalOptions{DiscardUnknown: true} |
Contributor
Author
There was a problem hiding this comment.
this is to make sure upgrade/downgrade test are backward compatible.
GuptaManan100
approved these changes
Mar 23, 2023
Contributor
GuptaManan100
left a comment
GuptaManan100
left a comment
There was a problem hiding this comment.
Just a suggestion. Other than that, LGTM
Contributor
|
Just realized, I am not a code-owner for the reparent endtoend tests. I'll fix that in a separate PR. |
mattlord
approved these changes
Mar 24, 2023
rsajwani
added a commit
to planetscale/vitess
that referenced
this pull request
Mar 24, 2023
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
4 tasks
GuptaManan100
pushed a commit
that referenced
this pull request
Mar 28, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Downgrad/Upgrade test (Reparent New Vtctl) is failing on v16.0 (https://github.com/vitessio/vitess/actions/runs/4466836285/jobs/7865121597)
In #12206 we added an additional field "super_read_only" to FullStatus message, with upgrade downgrade test we use N+1 (17) version of Vtctl along with N (v16) version of VTTablet. Since the test code does not have updated proto definition of FullStatus message (replicationdata.proto), it fails to Unmarshal the message object.
Solution:
1- If I use
then this will disregard the missing fields ...
Related Issue(s)
Checklist
Deployment Notes