Parser & query executor: support formalized ShowMigrations statement#12676
Closed
shlomi-noach wants to merge 5 commits intovitessio:mainfrom
Closed
Parser & query executor: support formalized ShowMigrations statement#12676shlomi-noach wants to merge 5 commits intovitessio:mainfrom
ShowMigrations statement#12676shlomi-noach wants to merge 5 commits intovitessio:mainfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
Type: Enhancement
shlomi-noach
requested review from
GuptaManan100,
arthurschreiber,
frouioui,
harshit-gangal,
mattlord,
rohit-nayak-ps and
systay
as code owners
Contributor
Author
|
This work will be simplified. Will probably close this PR and open a new, simpler one. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…es a ShowMigrationsPlan based on ShowBasic, in preparation for ShowBasic statement coming up in next releases Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Up till now, a
SHOW VITESS_MIGRATIONS ...statement was executed usingShowBasic.vtgateconstructed aSELECT *query which was then sent to tablets.As of this PR, we introduce a formal
ShowMigrationsstatement. This new statement is supported by bothvtgateandQueryExecutor, and sent to the underlying OnlineDDL executor, which then converts it to a SQL statement.However, since this change affects both
vtgateandvttablet, we also keep backwards compatibility.vtgatefirst attempts to send aShowMigrationsstatement, but if it gets anINVALID_ARGUMENTfromvttablet, then it falls back to plain SQL.This is expected to be merged in
v17.In
v18, we can remove the boilerplate code that supports backwards compatibility.Related Issue(s)
Checklist
Deployment Notes