go/vt/mysqlctl/backupstats: increment *_bytes metric by actual number of bytes#12501
Merged
vmg merged 6 commits intovitessio:mainfrom Mar 15, 2023
Merged
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
deepthi
reviewed
Feb 27, 2023
Collaborator
deepthi
left a comment
There was a problem hiding this comment.
Can you enhance one of the existing backup/restore endtoend tests to validate all the new stats?
Collaborator
Author
|
@deepthi can do! |
rsajwani
approved these changes
Mar 3, 2023
… of bytes Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
c41b552 to
2a71d59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recently merged detailed backup stats has a minor bug in that it is not actually counting # of bytes. I know I had this correct at least locally at some point, but looking through commits in #11979 it seems like it was always wrong 😵💫
Related Issue(s)
#11979
Checklist
Deployment Notes