Skip to content

Allow zero (in) date when setting up internal _vt schema (#12262)#12406

Merged
frouioui merged 1 commit intovitessio:release-16.0from
planetscale:backport-12262-on-16
Feb 22, 2023
Merged

Allow zero (in) date when setting up internal _vt schema (#12262)#12406
frouioui merged 1 commit intovitessio:release-16.0from
planetscale:backport-12262-on-16

Conversation

@frouioui
Copy link
Member

@frouioui frouioui commented Feb 21, 2023 •
edited
Loading

Description

This is a backport of #12262

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach @rohit-nayak-ps @frouioui
Allow zero (in) date when setting up internal _vt schema (vitessio#12262
8ca4837 
)

* Allow zero (in) date when setting up internal _vt schema

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* modify test sto include @@sql_mod query support

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Allow zero (in) date when setting up internal _vt schema

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* modify test sto include @@sql_mod query support

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Fix test failures

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Fix failing tests. Minor refactor

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* change sql_mode t omost permissive (empty)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* setPermissiveSQLMode

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* fixes per review

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Add missing mock query

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
@frouioui frouioui added Type: Bug Component: VReplication Backport This is a backport Component: General Changes throughout the code base Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Feb 21, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 21, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 21, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 21, 2023
@shlomi-noach
Copy link
Contributor

shlomi-noach commented Feb 21, 2023

Feel free to ignore Cluster (onlineddl_vrepl) failure (there's an open PR to fix it)

@frouioui frouioui merged commit 08362bc into vitessio:release-16.0 Feb 22, 2023
@frouioui frouioui deleted the backport-12262-on-16 branch February 22, 2023 06:23
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbussink dbussink dbussink approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi

Assignees

No one assigned

Labels

Backport This is a backport Component: General Changes throughout the code base Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Component: VReplication Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frouioui @shlomi-noach @dbussink