Use Ubuntu 20.04 for Release Builds#12202
Merged
mattlord merged 1 commit intovitessio:mainfrom Feb 1, 2023
Merged
Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Contributor
|
I was unable to backport this Pull Request to the following branches: |
mattlord
added a commit
to planetscale/vitess
that referenced
this pull request
Feb 1, 2023
Signed-off-by: Matt Lord <mattalord@gmail.com>
3 tasks
mattlord
added a commit
to planetscale/vitess
that referenced
this pull request
Feb 2, 2023
The underlying issue has now been addressed in: vitessio#12214 This reverts commit 4b3b37d. Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
added a commit
that referenced
this pull request
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This moves the release package build CI workflow to Ubuntu 20.04, which is the oldest supported Linux distro available on GitHub hosted runners today.
This will get us back to what we were using with v14 and the
vtorcbinary — which links in the nativesqliteClibrary viacgo— will be usable on a larger set of Linux distros. For additional details see: #12185We may want to investigate additional options at some point, even going so far as attempting to statically link
glibcinsqliteand using that resulting archive rather than shared object, but this PR gets us back to where we were and improves the situation significantly.Related Issue(s)
Checklist