Remove Dead Legacy Workflow Manager Code#12085
Merged
mattlord merged 5 commits intovitessio:mainfrom Jan 13, 2023
Merged
Conversation
This was pre-Legacy sharding, which was in turn pre-VReplication. Signed-off-by: Matt Lord <mattalord@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
deepthi
approved these changes
Jan 12, 2023
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Contributor
|
Folks, we missed the part that when we delete flags, we've to check if VTop is also using them. If it is, then we delete the usage there too. That's the last item in backward compatibility subsection of checklist. |
Contributor
|
Here is the fix for VTop - planetscale/vitess-operator#360 |
3 tasks
Contributor
|
This PR fixes release-15.0 too, so that upgrade-downgrade tests start working again - #12128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The legacy sharding code was removed in v15, but this old workflow management code is even older than the legacy sharding code. It did not work and was dead code, so is being removed here in v16.
Related Issue(s)
Checklist