backup: remove deprecated hook support#12066
Merged
deepthi merged 3 commits intovitessio:mainfrom Jan 11, 2023
Merged
Conversation
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
requested review from
GuptaManan100,
frouioui,
harshit-gangal,
mattlord,
rohit-nayak-ps and
rsajwani
as code owners
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Collaborator
Author
|
I have not created a separate issue for this task. If any reviewers feel that one is required, I'm happy to create it. |
mattlord
approved these changes
Jan 10, 2023
| // ExecuteBackup runs a backup based on given params. This could be a full or incremental backup. | ||
| // The function returns a boolean that indicates if the backup is usable, and an overall error. | ||
| func (be *BuiltinBackupEngine) ExecuteBackup(ctx context.Context, params BackupParams, bh backupstorage.BackupHandle) (bool, error) { | ||
| params.Logger.Infof("Hook: %v, Compress: %v", backupStorageHook, backupStorageCompress) |
Member
There was a problem hiding this comment.
Might be informative to instead log the params but IMO fine to just remove too.
Collaborator
Author
There was a problem hiding this comment.
I've added a log line that prints more info.
I0111 13:48:44.086977 11714 builtinbackupengine.go:179] Executing Backup at 2023-01-11 13:48:39.006292 -0800 PST m=+2.432865209 for keyspace/shard ks/0 on tablet vtbackup-2077360256, concurrency: 4, compress: true, incrementalFromPos:
| // and an overall error. | ||
| func (be *BuiltinBackupEngine) executeFullBackup(ctx context.Context, params BackupParams, bh backupstorage.BackupHandle) (bool, error) { | ||
|
|
||
| params.Logger.Infof("Hook: %v, Compress: %v", backupStorageHook, backupStorageCompress) |
Member
There was a problem hiding this comment.
Same comment as above for the log line.
Collaborator
Author
There was a problem hiding this comment.
This is a duplicate log line, because the exact same thing was already being logged just before we call this function. So I have left this deleted.
GuptaManan100
approved these changes
Jan 11, 2023
Contributor
GuptaManan100
left a comment
GuptaManan100
left a comment
There was a problem hiding this comment.
Did you check if the flags are used in the vitess operator?
Contributor
|
Okay, I have verified, its not used in VTop. |
Collaborator
Author
I didn't check, but I knew that this flag wasn't being used 😄 |
Signed-off-by: deepthi <deepthi@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In v15, we deprecated backup/restore hooks and provided a much better way of customizing compression/decompression of backups. This PR deletes the flags and code associated with backup/restore hooks.
Related Issue(s)
#11491 #10558 #10670 #7802
Checklist
Deployment Notes