vtgate advertised mysql server version to 8.0.31

[harshit-gangal]

Description

This PR updates the MySQL server version advertised by VTGate from 5.7.9 to 8.0.31

Related Issue(s)

• Closes Update vtgate advertised mysql version #11965
• Depends on Update the MySQL version used in the Docker lite images #11948

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
• If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

• Is it really necessary to add this flag?
• Flag names should be clear and intuitive (as far as possible)
• Help text should be descriptive.
• Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow should be required, the maintainer team should be notified.

Bug fixes

• There should be at least one unit or end-to-end test.
• The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

• There should be some code comments as to why things are implemented the way they are.

New/Existing features

• Should be documented, either by modifying the existing documentation or creating new documentation.
• New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• vtctl command output order should be stable and awk-able.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from VTop, if used there.

[dbussink]

We have another default version number here that we need to change together with this I think:

vitess/go/vt/sqlparser/parser.go

Lines 46 to 47 in ece6501

	// MySQLVersion is the version of MySQL that the parser would emulate
	var MySQLVersion = "50709" // default version if nothing else is stated

[deepthi]

This should be merged only after #11948 is fixed.

[GuptaManan100]

Approving to merge after the pre-requisites are met

[deepthi]

Website location to update: https://vitess.io/docs/16.0/overview/supported-databases/
We currently say

The VTGate proxy server advertises its version as MySQL 5.7.

[harshit-gangal]

This should be merged only after #11948 is fixed.

To my understanding, this should not be considered a blocker. Currently, VTGate emits 5.7 and we still release vitess/lite with 8.0.23. what will impact when VTGate emits 8.0.31?

[harshit-gangal]

Docs PR: vitessio/website#1337

[deepthi]

To my understanding, this should not be considered a blocker. Currently, VTGate emits 5.7 and we still release vitess/lite with 8.0.23. what will impact when VTGate emits 8.0.31?

This is actually a good point and I'm glad you raised it.
We need to keep the vtgate server version in sync with the default version we ship with vitess/lite. Currently the default vitess/lite image ships with 5.7. We need to make that 8.0 along with making the vtgate version change from 5.7 -> 8.0.
There's no reason why that cannot be done as part of this PR, but it is something we'll need to announce to the community.

As for the minor version mismatch, I don't know that it really matters. In theory, it is possible for frameworks to send queries based on MySQL minor version, and if they do then making vtgate present as 8.0.31 when the backing MySQL is 8.0.23 may be problematic. In practice, I have no idea whether any of the popular frameworks are doing this. So keeping these versions in sync is only a precaution to avoid breaking people who are running with defaults.

[deepthi]

If you want to make the default image change, all we need to do is change the symlink for docker/lite/Dockerfile.

[harshit-gangal]

If you want to make the default image change, all we need to do is change the symlink for docker/lite/Dockerfile.

done

[harshit-gangal]

While looking at this in regards to docker image, we pass in the advertised version

/vt/run.sh "8.0.31-vitess"

Docker image changes looks unrelated to the change in the PR. I will revert all the docker image changes made in this PR.

[harshit-gangal]

blocked for merge. waiting on #12054