Skip to content

Add manan and florent to Docker files CODEOWNERS#11981

Merged
GuptaManan100 merged 1 commit intomainfrom
update-CODEOWNERS
Dec 16, 2022
Merged

Add manan and florent to Docker files CODEOWNERS#11981
GuptaManan100 merged 1 commit intomainfrom
update-CODEOWNERS

Conversation

@frouioui
Copy link
Member

@frouioui frouioui commented Dec 16, 2022

Description

This PR fixes #11980.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@frouioui
Add manan and florent to Docker files CODEOWNERS
c1dd908 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Governance Backport to: release-14.0 labels Dec 16, 2022
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 16, 2022 •
edited by GuptaManan100
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui mentioned this pull request Dec 16, 2022
Merged
3 tasks
GuptaManan100
GuptaManan100 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank-you!

@GuptaManan100 GuptaManan100 merged commit ece6501 into main Dec 16, 2022
@GuptaManan100 GuptaManan100 deleted the update-CODEOWNERS branch December 16, 2022 09:06
This was referenced Dec 16, 2022
Merged
Merged
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 16, 2022

I was unable to backport this Pull Request to the following branches: release-13.0.

frouioui added a commit to planetscale/vitess that referenced this pull request Dec 16, 2022
@frouioui
Add manan and florent to Docker files CODEOWNERS (vitessio#11981)
5284b13 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Dec 27, 2022
@frouioui
Add manan and florent to Docker files CODEOWNERS (#11981) (#11984)
bdf0c25 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

+1 more reviewer

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Governance Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Manan and Florent to CODEOWNERS for Docker files

3 participants

@frouioui @GuptaManan100 @rohit-nayak-ps