Fix sending a ServerLost error when reading a packet fails#11920
Merged
harshit-gangal merged 1 commit intovitessio:mainfrom Dec 9, 2022
Merged
Fix sending a ServerLost error when reading a packet fails#11920harshit-gangal merged 1 commit intovitessio:mainfrom
harshit-gangal merged 1 commit intovitessio:mainfrom
Conversation
… server side error Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
frouioui
reviewed
Dec 9, 2022
frouioui
approved these changes
Dec 9, 2022
harshit-gangal
approved these changes
Dec 9, 2022
This was referenced Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Once a connection has received a connection error from MySQL, we close the connection in
dbconnand other callers. In order for this close to work properly we should be sending a MySQL.CRServerLosterror.All the callers of
readEphemeralPacketwrap the error and send this error so that the connection can be closed. However, there is one code-path that doesn't do this.We believe that is an issue. Not sending a mysql.
CRServerLosterror causes the connection to remain open and be reused for the rollback call, even though the connection isn't usable any more. This causes a panic in the code, since we didn't cleanup the state when we error out the first time.This PR fixes the issue after adding a failing test which ensures that we receive a
CRServerLosterror on MySQL crashing after only sending a field packet.Related Issue(s)
Checklist
Deployment Notes