Skip to content

Fix sending a ServerLost error when reading a packet fails#11920

Merged
harshit-gangal merged 1 commit intovitessio:mainfrom
planetscale:serverlost-con-close
Dec 9, 2022
Merged

Fix sending a ServerLost error when reading a packet fails#11920
harshit-gangal merged 1 commit intovitessio:mainfrom
planetscale:serverlost-con-close

Conversation

@GuptaManan100
Copy link
Copy Markdown
Contributor

@GuptaManan100 GuptaManan100 commented Dec 9, 2022

Description

Once a connection has received a connection error from MySQL, we close the connection in dbconn and other callers. In order for this close to work properly we should be sending a MySQL.CRServerLost error.
All the callers of readEphemeralPacket wrap the error and send this error so that the connection can be closed. However, there is one code-path that doesn't do this.

We believe that is an issue. Not sending a mysql.CRServerLost error causes the connection to remain open and be reused for the rollback call, even though the connection isn't usable any more. This causes a panic in the code, since we didn't cleanup the state when we error out the first time.

This PR fixes the issue after adding a failing test which ensures that we receive a CRServerLost error on MySQL crashing after only sending a field packet.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

… server side error

Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Dec 9, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: Panic in Rollback of a transaction after MySQL crash

3 participants