Skip to content

Upgrade to go1.19.4#11905

Merged
frouioui merged 2 commits intovitessio:mainfrom
planetscale:upgrade-main-to-go1.19.4
Dec 9, 2022
Merged

Upgrade to go1.19.4#11905
frouioui merged 2 commits intovitessio:mainfrom
planetscale:upgrade-main-to-go1.19.4

Conversation

@frouioui
Copy link
Copy Markdown
Member

@frouioui frouioui commented Dec 7, 2022

Description

This Pull Request upgrades the Go version of the project to go1.19.4.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
upgrade to go1.19.4
e28f542 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: General Changes throughout the code base go Early in Cycle These items are prioritised for the current release cycle labels Dec 7, 2022
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Dec 7, 2022 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui removed the Early in Cycle These items are prioritised for the current release cycle label Dec 7, 2022
deepthi
deepthi suggested changes Dec 7, 2022
View reviewed changes
docker/base/Dockerfile Outdated
# https://github.com/docker/hub-feedback/issues/292 is fixed.

ARG bootstrap_version=13
ARG bootstrap_version=13.2
Copy link
Copy Markdown
Collaborator

@deepthi deepthi Dec 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using a .2 version on main? We should be using 14.

Copy link
Copy Markdown
Member Author

@frouioui frouioui Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is solved by e816bdc

@frouioui
use bootstrap version 14
e816bdc 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui requested a review from deepthi December 8, 2022 07:49
@frouioui frouioui merged commit b26d509 into vitessio:main Dec 9, 2022
@frouioui frouioui deleted the upgrade-main-to-go1.19.4 branch December 9, 2022 10:07
@frouioui frouioui mentioned this pull request Dec 9, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsajwani rsajwani rsajwani approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

+2 more reviewers

@deepthi deepthi deepthi approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frouioui @deepthi @rsajwani @GuptaManan100