Skip to content

[Don't review] Issue#10363 ii#11706

Closed
rsajwani wants to merge 54 commits intovitessio:mainfrom
planetscale:Issue#10363_II
Closed

[Don't review] Issue#10363 ii#11706
rsajwani wants to merge 54 commits intovitessio:mainfrom
planetscale:Issue#10363_II

Conversation

@rsajwani
Copy link
Contributor

@rsajwani rsajwani commented Nov 15, 2022

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

rohit-nayak-ps and others added 7 commits October 12, 2022 22:33
@rohit-nayak-ps
Add sidecardb module
d39be36 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Remove metadata tables from init_db.sql
02f31d1 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Init sidecard db in EnsureConnectionAndDB, common entry point for all…
e3d099d 
… tablet types

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Disable withddl if new init mechanism is enabled
6b3f648 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Fix vttablet help output
acf8a56 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Remove references to metadata tables
b7d8a07 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rsajwani
Adding super read only user during tablet init
8fbc92c 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 15, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rsajwani
Merge remote-tracking branch 'upstream/main' into Issue#10363_II
e0e2f3f 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani
add new init sql file for unit test
afd71fb 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani changed the title Issue#10363 ii [Don't review] Issue#10363 ii Nov 15, 2022
@ramsemune ramsemune mentioned this pull request Nov 15, 2022
Open
@rsajwani rsajwani self-assigned this Nov 21, 2022
@rsajwani
enable super-readonly by default
483ef1e 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani
Merge remote-tracking branch 'upstream/main' into Issue#10363_II
3ba27f2 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani added Type: RFC Request For Comment Benchmark me Add label to PR to run benchmarks Component: Cluster management labels Nov 23, 2022
@rsajwani
Fixing some arrangement for super-read-only
0b09532 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@ramsemune ramsemune mentioned this pull request Nov 28, 2022
Open
rsajwani and others added 10 commits December 4, 2022 01:08
@rsajwani
Fix end to end tests
48fa50c 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani
fix rpc_replication issue
13e53fe 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani
Merge remote-tracking branch 'upstream/main' into Issue#10363_II
a23fd9e 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rohit-nayak-ps
Add sidecardb module
b7dac35 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Remove metadata tables from init_db.sql
7950c3c 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Init sidecard db in EnsureConnectionAndDB, common entry point for all…
18693db 
… tablet types

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Disable withddl if new init mechanism is enabled
cbd2948 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Fix vttablet help output
68541ed 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Remove references to metadata tables
26bf2e9 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Fix logic for schema init
d34e1ce 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rsajwani
Merge remote-tracking branch 'upstream/main' into Issue#10363_II
0b98e80 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@ramsemune ramsemune mentioned this pull request Dec 25, 2022
Open
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2023

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jan 22, 2023
@rsajwani rsajwani mentioned this pull request Jan 26, 2023
Closed
3 tasks
@rsajwani
Copy link
Contributor Author

rsajwani commented Jan 26, 2023

closed in favor of planetscale#77

@github-actions github-actions bot removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jan 27, 2023
This was referenced Jan 28, 2023
Closed
Merged
@deepthi
Copy link
Collaborator

deepthi commented Feb 21, 2023

superseded by #12206

@deepthi deepthi closed this Feb 21, 2023
@ramsemune ramsemune mentioned this pull request Mar 31, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 22, 2023
Open
This was referenced May 22, 2023
Open
Open
This was referenced Jun 20, 2023
Open
Open
Open
@ramsemune ramsemune mentioned this pull request Oct 1, 2023
Open
@ramsemune ramsemune mentioned this pull request Nov 25, 2023
Open
@ramsemune ramsemune mentioned this pull request Dec 19, 2023
Open
@ramsemune ramsemune mentioned this pull request Jan 9, 2024
Open
This was referenced Feb 2, 2024
Open
Open
This was referenced Feb 11, 2024
Open
Open
@ramsemune ramsemune mentioned this pull request Mar 22, 2024
Open
This was referenced Apr 29, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps will be requested when the pull request is marked ready for review rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord will be requested when the pull request is marked ready for review mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal will be requested when the pull request is marked ready for review harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay will be requested when the pull request is marked ready for review systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach will be requested when the pull request is marked ready for review shlomi-noach is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt will be requested when the pull request is marked ready for review timvaillancourt is a code owner

@beingnoble03 beingnoble03 Awaiting requested review from beingnoble03 beingnoble03 will be requested when the pull request is marked ready for review beingnoble03 is a code owner

@dbussink dbussink Awaiting requested review from dbussink dbussink will be requested when the pull request is marked ready for review dbussink is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@rsajwani rsajwani

Labels

Benchmark me Add label to PR to run benchmarks Component: Cluster management Type: RFC Request For Comment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rsajwani @deepthi @rohit-nayak-ps