fix(sec): upgrade gopkg.in/yaml.v3 to 3.0.0#11643
fix(sec): upgrade gopkg.in/yaml.v3 to 3.0.0#11643chncaption wants to merge 1 commit intovitessio:mainfrom
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
There was a problem hiding this comment.
Hello @chncaption, thank you for your first contribution to our project.
The version v3.0.0 is not the latest release of go-yaml. Can you bump the version to v3.0.1 which is the latest? That latest version fixes a similar panic (go-yaml/yaml#665) to the one that generated the CVE (go-yaml/yaml#666). It would thus be safer to upgrade go-yaml to v3.0.1.
Another thing, in order to approve and merge your Pull Request you need to sign your commit, which will make the DCO status check go green. You can find the instructions to do so here: https://github.com/vitessio/vitess/pull/11643/checks?check_run_id=9329481430.
Thank you!
|
@chncaption we cannot accept this PR unless the commit is signed off. Can you please fix that? |
|
Fixed in #11741 |
What happened?
There are 1 security vulnerabilities found in gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
What did I do?
Upgrade gopkg.in/yaml.v3 from v3.0.0-20210107192922-496545a6307b to 3.0.0 for vulnerability fix
What did you expect to happen?
Ideally, no insecure libs should be used.
The specification of the pull request
PR Specification from OSCS