Move towards MySQL 8.0 as the default template generation (#11153)

[rsajwani]

• Move towards MySQL 8.0 as the default template generation

This upgrades the remaining things to Ubuntu 20.04 and makes MySQL 8.0 the default we run tests against. We still have tests for MySQL 5.7 but those are now explicitly opted into.

This should finish up the Ubuntu 20.04 upgrade and also makes things easier for the future when we need to upgrade again.

Signed-off-by: Dirkjan Bussink d.bussink@gmail.com

• CI: rename shard vtorc_8.0 to vtorc_5.7, change expected test output for 8.0

Signed-off-by: deepthi deepthi@planetscale.com

• CI: increase timeout for 8.0 tests on the actual test step from 30 to 45 mins

Signed-off-by: deepthi deepthi@planetscale.com

• CI: increase timeout to 45 minutes for mysql57 tests too. We really only need this for vtorc, but I've made the change to the template so all tests get it.

Signed-off-by: deepthi deepthi@planetscale.com

• CI: fix vtorc test to work with both 5.7 and 8.0

Signed-off-by: deepthi deepthi@planetscale.com

• CI: missed docker flag in mysql57 template, one more fix to vtorc test

Signed-off-by: deepthi deepthi@planetscale.com

• removing spaces from pb file

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

• removing spaces in pb file part 2

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

Signed-off-by: Dirkjan Bussink d.bussink@gmail.com
Signed-off-by: deepthi deepthi@planetscale.com
Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com
Co-authored-by: deepthi deepthi@planetscale.com
Co-authored-by: Rameez Sajwani rameezwazirali@hotmail.com

Description

There are two main changes in CI workflow been done as part of this PR.

• Move to ubuntu 20.04
• Upgrade Mysql 5.7 to Mysql 8.0.25

This PR cherry-pick (#11153) the change from main where we have made Mysql8.0.x as default database (from Mysql 5.7). There were certain issues which were hard to cherry-pick from main as a result of moving Mysql8.0, especially failures in onlineddl_vrepl_suite which compelled us to pin Mysql version to 8.0.25. For example we no longer use Tengo whereas in v13 we used it for schemadiff. To remove Tango from v13 is a bigger work item.

Installing Deb files for 8.0.25 was giving a lot of pain during requisite deployment, therefore, we choose to un-tar the package with binaries and set VT_MYSQL_ROOT directory during run end-to-end step in workflow.

Apart from workflow changes, there were some compatibility issues between Mysql5.7 and Mysql8.0 which resulted in test failures. They are also addressed in this PR.

Related Issue(s)

#11511

Checklist

• "Backport me!" label has been added if this change should be backported
• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

• Is it really necessary to add this flag?
• Flag names should be clear and intuitive (as far as possible)
• Help text should be descriptive.
• Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow should be required, the maintainer team should be notified.

Bug fixes

• There should be at least one unit or end-to-end test.
• The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

• There should be some code comments as to why things are implemented the way they are.

New/Existing features

• Should be documented, either by modifying the existing documentation or creating new documentation.
• New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• vtctl command output order should be stable and awk-able.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from VTop, if used there.

[harshit-gangal]

not sure about this formatting change, what would have caused this.

[harshit-gangal]

LGTM for query serving side changes.

[rohit-nayak-ps]

@mattlord, I noticed we have this commit (related to the messaging deadlock) in this issue: 6f0b569. Is that affected by switching to mysql 8.0 for testing?

[rohit-nayak-ps]

vrep related changes look good.