Skip to content

[cherry-pick]Move CI workflow to use latest community version of mysql 8.0 (#11493)#11618

Merged
GuptaManan100 merged 1 commit intovitessio:mainfrom
planetscale:cherrypick-11493
Nov 3, 2022
Merged

[cherry-pick]Move CI workflow to use latest community version of mysql 8.0 (#11493)#11618
GuptaManan100 merged 1 commit intovitessio:mainfrom
planetscale:cherrypick-11493

Conversation

@rsajwani
Copy link
Copy Markdown
Contributor

@rsajwani rsajwani commented Nov 1, 2022

Description

Cherry-pick #11493

Our current git workflows are not using latest version of mysql. We are using latest version of percona which has not been updated since Aug 2021
https://repo.percona.com/apt/

here is what we are using in our template file
wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb

This is preventing us to test vitess code against that latest version of mysql. We should always run main against the latest version of mysql.

Related Issue(s)

#11511

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

…io#11493)

* Move CI to mysql80

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fix typo

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fixing typo

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* moving to apt-config 8.2

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Nov 1, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rsajwani rsajwani self-assigned this Nov 2, 2022
@rsajwani rsajwani added Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Nov 2, 2022
@rsajwani rsajwani marked this pull request as ready for review November 2, 2022 00:22
@rsajwani rsajwani requested a review from deepthi November 2, 2022 00:22
@rsajwani
Copy link
Copy Markdown
Contributor Author

rsajwani commented Nov 2, 2022

vttablet_prscomplex is failing because of changes not related to this PR.

@GuptaManan100 GuptaManan100 merged commit 531ba1b into vitessio:main Nov 3, 2022
@GuptaManan100 GuptaManan100 deleted the cherrypick-11493 branch November 3, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants