Skip to content

[cherry-pick] remove excessive backup decompression logging (#11479)#11586

Merged
mattlord merged 2 commits intovitessio:mainfrom
planetscale:cherrypick-11479
Oct 28, 2022
Merged

[cherry-pick] remove excessive backup decompression logging (#11479)#11586
mattlord merged 2 commits intovitessio:mainfrom
planetscale:cherrypick-11479

Conversation

@rsajwani
Copy link
Copy Markdown
Contributor

@rsajwani rsajwani commented Oct 26, 2022

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

Description

Forward port of: #11479

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

* remove excessive logging

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* code feeback

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fixing typo

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 26, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rsajwani rsajwani changed the title remove excessive logging (#11479) [cherry-pick]remove excessive logging (#11479) Oct 26, 2022
@rsajwani rsajwani self-assigned this Oct 26, 2022
@rsajwani rsajwani added Type: Bug Component: General Changes throughout the code base labels Oct 26, 2022
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani marked this pull request as ready for review October 27, 2022 22:36
@mattlord mattlord changed the title [cherry-pick]remove excessive logging (#11479) [cherry-pick] remove excessive backup logging (#11479) Oct 28, 2022
@mattlord mattlord added Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed Type: Bug labels Oct 28, 2022
@mattlord mattlord changed the title [cherry-pick] remove excessive backup logging (#11479) [cherry-pick] remove excessive backup decompression logging (#11479) Oct 28, 2022
@mattlord mattlord merged commit 133c855 into vitessio:main Oct 28, 2022
@mattlord mattlord deleted the cherrypick-11479 branch October 28, 2022 00:23
@mattlord mattlord added Component: Backup and Restore and removed Component: General Changes throughout the code base labels Oct 28, 2022
@rsajwani rsajwani mentioned this pull request Oct 28, 2022
100 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Backup and Restore Forwardport Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too many warning log statements during backup

2 participants