Skip to content

minimize flags for vtexplain#11516

Closed
systay wants to merge 2 commits intovitessio:release-15.0from
planetscale:vtexplain-less-flags
Closed

minimize flags for vtexplain#11516
systay wants to merge 2 commits intovitessio:release-15.0from
planetscale:vtexplain-less-flags

Conversation

@systay
Copy link
Copy Markdown
Collaborator

@systay systay commented Oct 17, 2022

Description

Trying to remove flags not used by vtexplain.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 17, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@systay systay added Type: Internal Cleanup Component: vtexplain changes made to vtexplain code labels Oct 18, 2022
@systay systay mentioned this pull request Oct 18, 2022
100 tasks
@systay systay added the Forwardport to: main This will forward port the PR to the main branch label Oct 18, 2022
Copy link
Copy Markdown
Contributor

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

…s-flags

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Oct 18, 2022

@systay @rsajwani if this PR is a subset of #11522, we should close this and just go forward with #11522.
Can one of you validate this?

@rsajwani
Copy link
Copy Markdown
Contributor

@systay , most of the flags have been taken care of in my PR.. i will add the missing one. I think we should close this PR

@systay systay closed this Oct 19, 2022
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 19, 2022

I was unable to forwardport this Pull Request to the following branches: main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: vtexplain changes made to vtexplain code Forwardport to: main This will forward port the PR to the main branch Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants