fix: reserve connection to follow query timeout when outside of transaction#11490
Merged
harshit-gangal merged 2 commits intovitessio:mainfrom Oct 14, 2022
Merged
fix: reserve connection to follow query timeout when outside of transaction#11490harshit-gangal merged 2 commits intovitessio:mainfrom
harshit-gangal merged 2 commits intovitessio:mainfrom
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
1c2d9c2 to
f579799
Compare
…action Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
f579799 to
fa1deee
Compare
frouioui
approved these changes
Oct 14, 2022
harshit-gangal
added a commit
that referenced
this pull request
Oct 14, 2022
[release-15.0] fix: reserve connection to follow query timeout when outside of transaction (#11490)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug in reserve connection query execution on
ReserveExecuteandReserveStreamExecutecalls to not use transaction timeout for queries outside of transaction.Related Issue(s)
Checklist
Deployment Notes