Skip to content

Full Status tab improvements for VTAdmin #11470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuptaManan100 merged 4 commits into from
Oct 13, 2022
+21 −1
Merged

Full Status tab improvements for VTAdmin #11470

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
322e715
feat: add replacer and code to always print semi-sync fields and deco…
GuptaManan100 Oct 12, 2022
7b9ba65
refactor: prettify the changed file
GuptaManan100 Oct 12, 2022
43a35fe
feat: fix replication state strings and simplify code
GuptaManan100 Oct 13, 2022
07018ca
Merge remote-tracking branch 'upstream/main' into vtadmin-full-status…
GuptaManan100 Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion web/vtadmin/src/components/routes/tablet/FullStatus.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,19 @@ interface Props {
tablet: vtadmin.Tablet;
}

function stateReplacer(key: string, val: number) {
if (key === 'io_state' || key === 'sql_state') {
if (val === 3) {
return 'Running';
} else if (val === 2) {
return 'Connecting';
} else if (val === 1) {
return 'Stopped';
}
}
return val;
}

const FullStatus: React.FC<Props> = ({ tablet }) => {
const { data, error } = useGetFullStatus({
// Ok to use ? operator here; if params are null
Expand All @@ -31,7 +44,14 @@ const FullStatus: React.FC<Props> = ({ tablet }) => {
);
}

return <Code code={JSON.stringify(data, null, 2)} />;
if (data && data.status) {
data.status.semi_sync_primary_enabled = !!data.status.semi_sync_primary_enabled;
data.status.semi_sync_replica_enabled = !!data.status.semi_sync_replica_enabled;
data.status.semi_sync_primary_status = !!data.status.semi_sync_primary_status;
data.status.semi_sync_replica_status = !!data.status.semi_sync_replica_status;
}

return <Code code={JSON.stringify(data, stateReplacer, 2)} />;
};

export default FullStatus;