[RFC] Standardized viper framework for vitess configuration parameters#11456

Merged

ajm188 merged 100 commits intovitessio:mainfrom

planetscale:andrew/viper-rfc

May 25, 2023

Commits on May 23, 2023

Taking a stab at a way to standardize viper usage
Andrew Mason
committed
port go/trace to viper-bound flags
Andrew Mason
committed
add viperget subpackage
Andrew Mason
committed
add viperget subpackage
Andrew Mason
committed
Ensure viper values are bound prior to access
Andrew Mason
committed
wip: workin on my docs
Andrew Mason
committed
WIP: config reading
Andrew Mason
committed
lol whoops
Andrew Mason
committed
wip: vipersync for threadsafe(ish) watched configs
Andrew Mason
committed
Some threadsafety improvements, not quite there yet
Andrew Mason
committed
Add Subscribe/Notify api so live configs don't need to poll for updates
Andrew Mason
committed
fix adapter signature to what i meant the first time
Andrew Mason
committed
begrudgingly come crawling back to an RWMutex implementation
Andrew Mason
committed
adjust public Bind method (and only the public version) to allow secondary calls
Andrew Mason
committed
add Error handling type for reading in configs
Andrew Mason
committed
change vipersync Watch signature, also ensure we read in the config at least once before returning to the caller
Andrew Mason
committed
refactor vipersync.Viper a bit
Andrew Mason
committed
More refactors to vipersync:
Andrew Mason
committed
WIP WIP WIP checkpointing before i blow away this api for a new version
Andrew Mason
committed
wip on v2 of viperutil api
Andrew Mason
committed
WIP WIP WIP: update trace pkg to use new api (mostly)
Andrew Mason
committed
WIP: example of dynamic variable and getting notified of config changes
Andrew Mason
committed
fix default workdir override
Andrew Mason
committed
fix watch for when no config file was used
Andrew Mason
committed
provide mechanism to stub values for tests
Andrew Mason
committed
update usage in go/trace to new api
Andrew Mason
committed
update azblobbackupstorage to use new API
Andrew Mason
committed
fix config-handling parsing
Andrew Mason
committed
add test for config watching
Andrew Mason
committed
cleaning up some TODO markers
Andrew Mason
committed
starting to work on doc comments
Andrew Mason
committed
more docs
Andrew Mason
committed
document GetPath and add example test
Andrew Mason
committed
copyright headers
Andrew Mason
committed
finish switch case for handling config-file finding errors
Andrew Mason
committed
document sync subpackage
Andrew Mason
committed
document config stuff
Andrew Mason
committed
more docs
Andrew Mason
committed
document internal/log
Andrew Mason
committed
document Options and Configure
Andrew Mason
committed
rename
Andrew Mason
committed
more test cases for GetFuncForType
Andrew Mason
committed
more cases
Andrew Mason
committed
struct support
Andrew Mason
committed
support complex types
Andrew Mason
committed
map types, realizing we cannot support interfaces
Andrew Mason
committed
finish tests
Andrew Mason
committed
preserve usage for seconds decoder
Andrew Mason
committed
more docs
Andrew Mason
committed
bye bye v1
Andrew Mason
committed
mv go/viperutil/v2 => go/viperutil and update everythingggggggggg
Andrew Mason
committed
cleanup todo that is done
Andrew Mason
committed
start documenting new stuff
Andrew Mason
committed
delete most of the old docs
Andrew Mason
committed
flaggy flag docs
Andrew Mason
committed
config file stuff
Andrew Mason
committed
docs are done
Andrew Mason
committed
go mod tidy
Andrew Mason
committed
gofmt 🙃
Andrew Mason
committed
document Debug func
Andrew Mason
committed
document StringEnum types
Andrew Mason
committed
add debug endpoint to see the full config
Andrew Mason
committed
add registry.Combined
Andrew Mason
committed
add Set to Value interface and implementations
Andrew Mason
committed
support re-persistence of in-memory changes for existing debugenv APIs
Andrew Mason
committed
bugfixes to config persistence
Andrew Mason
committed
fix sync loading to work with re-persistence
Andrew Mason
committed
make discovery.min_number_serving_vttablets a dynamic viper value
Andrew Mason
committed
update comments
Andrew Mason
committed
configure the rest of discovery replicationlag settings
Andrew Mason
committed
remove example code
Andrew Mason
committed
fix bindings now that live gets reset
Andrew Mason
committed
default to ignore
Andrew Mason
committed
return empty cancel func to not panic
Andrew Mason
committed
no double registrations
Andrew Mason
committed
update flag testdata
Andrew Mason
committed
dumb dumb
Andrew Mason
committed
templatize (which requires further escaping)
Andrew Mason
committed
lint
Andrew Mason
committed
docs
Andrew Mason
committed
Update doc/viper/viper.md

authored and
Andrew Mason
committed
back to "warn on default", update tests to handle it
Andrew Mason
committed
flag testdata
Andrew Mason
committed
fix filtering quirk
Andrew Mason
committed
better newline handling to avoid double-newline at end
Andrew Mason
committed
refactor to colocate persistence with the sync viper
Andrew Mason
committed
forgot to copy over non-blocking send
Andrew Mason
committed
Update doc/viper/viper.md

authored and
Andrew Mason
committed
net.JoinHostPort
Andrew Mason
committed
reorder imports
Andrew Mason
committed
cleanup TODO panic
Andrew Mason
committed
error string formatting
Andrew Mason
committed
update comments
Andrew Mason
committed
copyright year update
Andrew Mason
committed
delete empty file
Andrew Mason
committed
extract function for initializing the viper config
Andrew Mason
committed
update example package
Andrew Mason
committed
more docs
Andrew Mason
committed
vterrors
Andrew Mason
committed

Commits on May 24, 2023

bigger time interval
Andrew Mason
committed