Skip to content

[main] Stats Flags: include stats flags in the correct binaries (#11450)#11453

Merged
deepthi merged 1 commit intomainfrom
forwardport-11450-to-main
Oct 21, 2022
Merged

[main] Stats Flags: include stats flags in the correct binaries (#11450)#11453
deepthi merged 1 commit intomainfrom
forwardport-11450-to-main

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Oct 6, 2022

Description

This is a forwardport of #11450.

…e correct binary.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@vitess-bot vitess-bot bot requested review from ajm188 and deepthi as code owners October 6, 2022 20:31
@vitess-bot vitess-bot bot added Component: General Changes throughout the code base Forwardport Type: Bug labels Oct 6, 2022
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Oct 6, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@deepthi
Copy link
Collaborator

deepthi commented Oct 14, 2022

can ignore web test failure for now, it's flaky, and we are going to delete it in a couple of weeks.

Copy link
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deepthi deepthi merged commit 30f2a77 into main Oct 21, 2022
@deepthi deepthi deleted the forwardport-11450-to-main branch October 21, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Forwardport Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants