Fix vtbackup binary by adding the flags it needs that we missed before#11417
Fix vtbackup binary by adding the flags it needs that we missed before#11417GuptaManan100 merged 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
|
|
||
| func init() { | ||
| for _, cmd := range []string{"mysqlctl", "mysqlctld", "vtcombo", "vttablet", "vttestserver", "vtctld", "vtctldclient", "vtexplain"} { | ||
| for _, cmd := range []string{"mysqlctl", "mysqlctld", "vtcombo", "vttablet", "vttestserver", "vtctld", "vtctldclient", "vtexplain", "vtbackup"} { |
There was a problem hiding this comment.
I would think vtbackup, vttablet, and maybe vtctld need backup flags. We can pare this down later.
There was a problem hiding this comment.
I am going ahead and merging this PR, because I want the latest lite image to be built so that I can continue testing planetscale/vitess-operator#324. We can add these flags to vttablet and vtctld in a follow up PR if needed.
There was a problem hiding this comment.
We have to do the opposite, i.e, remove the other binaries: mysqlctl, vtexplain etc.
Not sure whether vtcombo and vttestserver are supposed to support backups.
There was a problem hiding this comment.
vtbackup, vttablet, and m
Yes vttablet , vtctld will also need backup flags.
Description
This PR adds the flags that
vtbackupneeds but we missed to add them during the flag work. These were found because of VTop failures while running the backup end to end tests.Related Issue(s)
pflaginstead offlagand add make them package private. #10697Checklist
Deployment Notes