Skip to content

Fix vtbackup binary by adding the flags it needs that we missed before#11417

Merged
GuptaManan100 merged 1 commit intovitessio:mainfrom
planetscale:vtbackup-fix-flags
Oct 1, 2022
Merged

Fix vtbackup binary by adding the flags it needs that we missed before#11417
GuptaManan100 merged 1 commit intovitessio:mainfrom
planetscale:vtbackup-fix-flags

Conversation

@GuptaManan100
Copy link
Contributor

Description

This PR adds the flags that vtbackup needs but we missed to add them during the flag work. These were found because of VTop failures while running the backup end to end tests.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 1, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@GuptaManan100 GuptaManan100 requested a review from rsajwani October 1, 2022 14:15
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Backup and Restore Component: CLI Type: Internal Cleanup and removed Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Oct 1, 2022

func init() {
for _, cmd := range []string{"mysqlctl", "mysqlctld", "vtcombo", "vttablet", "vttestserver", "vtctld", "vtctldclient", "vtexplain"} {
for _, cmd := range []string{"mysqlctl", "mysqlctld", "vtcombo", "vttablet", "vttestserver", "vtctld", "vtctldclient", "vtexplain", "vtbackup"} {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think vtbackup, vttablet, and maybe vtctld need backup flags. We can pare this down later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I have no idea. Maybe @deepthi or @rsajwani know 🤷‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going ahead and merging this PR, because I want the latest lite image to be built so that I can continue testing planetscale/vitess-operator#324. We can add these flags to vttablet and vtctld in a follow up PR if needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to do the opposite, i.e, remove the other binaries: mysqlctl, vtexplain etc.
Not sure whether vtcombo and vttestserver are supposed to support backups.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vtbackup, vttablet, and m

Yes vttablet , vtctld will also need backup flags.

@GuptaManan100 GuptaManan100 merged commit c9f018b into vitessio:main Oct 1, 2022
@GuptaManan100 GuptaManan100 deleted the vtbackup-fix-flags branch October 1, 2022 15:13
Copy link
Contributor

@rsajwani rsajwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants