Skip to content

[tools/rowlog] Migrate to pflag#11412

Merged
rohit-nayak-ps merged 2 commits intovitessio:mainfrom
planetscale:andrew/pflag/rowlog
Oct 1, 2022
Merged

[tools/rowlog] Migrate to pflag#11412
rohit-nayak-ps merged 2 commits intovitessio:mainfrom
planetscale:andrew/pflag/rowlog

Conversation

@ajm188
Copy link
Contributor

@ajm188 ajm188 commented Sep 30, 2022

Description

Also some tidying, and a new flag to handle that resumability test commented-out code

Related Issue(s)

Closes #11408

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Andrew Mason added 2 commits September 30, 2022 14:28
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Closes vitessio#11408.

Signed-off-by: Andrew Mason <andrew@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 30, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@deepthi deepthi added this to the v15.0 milestone Sep 30, 2022
Copy link
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit b389dc1 into vitessio:main Oct 1, 2022
@rohit-nayak-ps rohit-nayak-ps deleted the andrew/pflag/rowlog branch October 1, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch flag definitions to be on pflag instead of flag in package tool/rowlog

3 participants