Skip to content

Enable VTOrc in backup tests#11410

Merged
GuptaManan100 merged 4 commits intovitessio:mainfrom
planetscale:vtorc-in-backup-tests
Oct 1, 2022
Merged

Enable VTOrc in backup tests#11410
GuptaManan100 merged 4 commits intovitessio:mainfrom
planetscale:vtorc-in-backup-tests

Conversation

@GuptaManan100
Copy link
Copy Markdown
Contributor

Description

This PR enables VTOrc for the backup tests that take backup of a replica. Unfortunately, we can't enable VTOrc for the tests that take backup from primary tablets, since VTOrc will see there is no primary and end up promoting one which interferes with the tests invariants.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Sep 30, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

Signed-off-by: Manan Gupta <manan@planetscale.com>
@rsajwani
Copy link
Copy Markdown
Contributor

LGTM

Signed-off-by: Manan Gupta <manan@planetscale.com>
…e VTOrc performance

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
Copy link
Copy Markdown
Contributor Author

GuptaManan100 commented Oct 1, 2022

The reduction in the topo-refresh-time for VTOrc is a nice optimization in making the tests faster.

Before -
Screenshot 2022-10-01 at 2 02 49 PM

After -
Screenshot 2022-10-01 at 1 52 52 PM

This just helps VTOrc setup faster, so it shaves off about 10 seconds from all the tests. Earlier with the default, it took VTOrc 15 seconds to even read the tablets' information from the topology server. With the flag change, it discovers the tablets in 3 or 6 seconds. Once it has read the tablets for the first time, it doesn't matter much when we refresh the information because none of the tests actually change the tablet record. The operations that do, automatically trigger a refresh irrespective of the timer. So overall it has a lower impact for long-running tests, but is much more useful for shorter tests.

// This is used to check that replication has caught up with the changes on primary.
func VerifyRowsInTabletForTable(t *testing.T, vttablet *Vttablet, ksName string, expectedRows int, tableName string) {
timeout := time.Now().Add(10 * time.Second)
timeout := time.Now().Add(1 * time.Minute)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This timeout has been increased for VTOrc. With the defaults, it takes VTOrc 15 seconds to discover the tablets and then it can start repairing them. This wait was for 10 seconds which turned out to be too small. I have improved VTOrc performance ☝️, but it doesn't hurt to increase the timeout.

@GuptaManan100 GuptaManan100 merged commit 475a1d4 into vitessio:main Oct 1, 2022
@GuptaManan100 GuptaManan100 deleted the vtorc-in-backup-tests branch October 1, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants