Enable VTOrc in backup tests#11410
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Manan Gupta <manan@planetscale.com>
|
LGTM |
Signed-off-by: Manan Gupta <manan@planetscale.com>
…e VTOrc performance Signed-off-by: Manan Gupta <manan@planetscale.com>
|
The reduction in the topo-refresh-time for VTOrc is a nice optimization in making the tests faster. This just helps VTOrc setup faster, so it shaves off about 10 seconds from all the tests. Earlier with the default, it took VTOrc 15 seconds to even read the tablets' information from the topology server. With the flag change, it discovers the tablets in 3 or 6 seconds. Once it has read the tablets for the first time, it doesn't matter much when we refresh the information because none of the tests actually change the tablet record. The operations that do, automatically trigger a refresh irrespective of the timer. So overall it has a lower impact for long-running tests, but is much more useful for shorter tests. |
| // This is used to check that replication has caught up with the changes on primary. | ||
| func VerifyRowsInTabletForTable(t *testing.T, vttablet *Vttablet, ksName string, expectedRows int, tableName string) { | ||
| timeout := time.Now().Add(10 * time.Second) | ||
| timeout := time.Now().Add(1 * time.Minute) |
There was a problem hiding this comment.
This timeout has been increased for VTOrc. With the defaults, it takes VTOrc 15 seconds to discover the tablets and then it can start repairing them. This wait was for 10 seconds which turned out to be too small. I have improved VTOrc performance ☝️, but it doesn't hurt to increase the timeout.


Description
This PR enables VTOrc for the backup tests that take backup of a
replica. Unfortunately, we can't enable VTOrc for the tests that take backup fromprimarytablets, since VTOrc will see there is no primary and end up promoting one which interferes with the tests invariants.Related Issue(s)
Checklist
Deployment Notes