Skip to content

flags etc: delete old flags and stats, add deprecation notice to release notes#11402

Merged
rohit-nayak-ps merged 3 commits intovitessio:mainfrom
planetscale:ds-deprecations-2
Oct 1, 2022
Merged

flags etc: delete old flags and stats, add deprecation notice to release notes#11402
rohit-nayak-ps merged 3 commits intovitessio:mainfrom
planetscale:ds-deprecations-2

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Sep 30, 2022

Description

  • remove master stats
  • remove deprecated vtctl command sub flags
  • add deprecation notice for prefill flags

Related Issue(s)

#5960

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

…ase notes

Signed-off-by: deepthi <deepthi@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Sep 30, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@deepthi deepthi requested review from mattlord and rohit-nayak-ps and removed request for notfelineit and rafael September 30, 2022 00:48
@deepthi deepthi added Component: VReplication Type: Internal Cleanup Component: Observability Pull requests that touch tracing/metrics/monitoring labels Sep 30, 2022
… deprecated tablet_type

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi added this to the v15.0 milestone Sep 30, 2022
…deprecated tablet_type

Signed-off-by: deepthi <deepthi@planetscale.com>
Copy link
Copy Markdown
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit 3f73bdb into vitessio:main Oct 1, 2022
@rohit-nayak-ps rohit-nayak-ps deleted the ds-deprecations-2 branch October 1, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Observability Pull requests that touch tracing/metrics/monitoring Component: VReplication Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants