Skip to content

Move dbconfigs to pflag and remove deprecated flags #11336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattlord merged 7 commits into from
Sep 30, 2022
Merged

Move dbconfigs to pflag and remove deprecated flags #11336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cfefc7d
Migrate dbconfigs to pflag
mattlord Sep 29, 2022
6ada721
Remove no longer needed function
mattlord Sep 29, 2022
a619749
Address review comments and test failures
mattlord Sep 30, 2022
3c47aa3
Revert this bit as it changed behavior and caused some failures
mattlord Sep 30, 2022
097c6ab
Fix vttestserver unit tests
mattlord Sep 30, 2022
b7e81d1
Fix vttestserver unit tests
mattlord Sep 30, 2022
85d95f3
Update vttestserver help output
mattlord Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions go/flags/endtoend/mysqlctl.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,6 @@ Global flags:
--catch-sigpipe catch and ignore SIGPIPE on stdout and stderr if specified
--compression-engine-name string compressor engine used for compression. (default "pargzip")
--compression-level int what level to pass to the compressor. (default 1)
--db-config-dba-charset string deprecated: use db_charset (default "utf8mb4")
--db-config-dba-flags uint deprecated: use db_flags
--db-config-dba-flavor string deprecated: use db_flavor
--db-config-dba-host string deprecated: use db_host
--db-config-dba-pass string db dba deprecated: use db_dba_password
--db-config-dba-port int deprecated: use db_port
--db-config-dba-server_name string deprecated: use db_server_name
--db-config-dba-ssl-ca string deprecated: use db_ssl_ca
--db-config-dba-ssl-ca-path string deprecated: use db_ssl_ca_path
--db-config-dba-ssl-cert string deprecated: use db_ssl_cert
--db-config-dba-ssl-key string deprecated: use db_ssl_key
--db-config-dba-uname string deprecated: use db_dba_user (default "vt_dba")
--db-config-dba-unixsocket string deprecated: use db_socket
--db-credentials-file string db credentials file; send SIGHUP to reload this file
--db-credentials-server string db credentials server type ('file' - file implementation; 'vault' - HashiCorp Vault implementation) (default "file")
--db-credentials-vault-addr string URL to Vault server
Expand Down
13 changes: 0 additions & 13 deletions go/flags/endtoend/mysqlctld.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,6 @@ Usage of mysqlctld:
--catch-sigpipe catch and ignore SIGPIPE on stdout and stderr if specified
--compression-engine-name string compressor engine used for compression. (default "pargzip")
--compression-level int what level to pass to the compressor. (default 1)
--db-config-dba-charset string deprecated: use db_charset (default "utf8mb4")
--db-config-dba-flags uint deprecated: use db_flags
--db-config-dba-flavor string deprecated: use db_flavor
--db-config-dba-host string deprecated: use db_host
--db-config-dba-pass string db dba deprecated: use db_dba_password
--db-config-dba-port int deprecated: use db_port
--db-config-dba-server_name string deprecated: use db_server_name
--db-config-dba-ssl-ca string deprecated: use db_ssl_ca
--db-config-dba-ssl-ca-path string deprecated: use db_ssl_ca_path
--db-config-dba-ssl-cert string deprecated: use db_ssl_cert
--db-config-dba-ssl-key string deprecated: use db_ssl_key
--db-config-dba-uname string deprecated: use db_dba_user (default "vt_dba")
--db-config-dba-unixsocket string deprecated: use db_socket
--db-credentials-file string db credentials file; send SIGHUP to reload this file
--db-credentials-server string db credentials server type ('file' - file implementation; 'vault' - HashiCorp Vault implementation) (default "file")
--db-credentials-vault-addr string URL to Vault server
Expand Down
92 changes: 0 additions & 92 deletions go/flags/endtoend/vtbackup.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,98 +10,6 @@ Usage of vtbackup:
--ceph_backup_storage_config string Path to JSON config file for ceph backup storage. (default "ceph_backup_config.json")
--concurrency int (init restore parameter) how many concurrent files to restore at once (default 4)
--consul_auth_static_file string JSON File to read the topos/tokens from.
--db-config-allprivs-charset string deprecated: use db_charset (default "utf8mb4")
--db-config-allprivs-flags uint deprecated: use db_flags
--db-config-allprivs-flavor string deprecated: use db_flavor
--db-config-allprivs-host string deprecated: use db_host
--db-config-allprivs-pass string db allprivs deprecated: use db_allprivs_password
--db-config-allprivs-port int deprecated: use db_port
--db-config-allprivs-server_name string deprecated: use db_server_name
--db-config-allprivs-ssl-ca string deprecated: use db_ssl_ca
--db-config-allprivs-ssl-ca-path string deprecated: use db_ssl_ca_path
--db-config-allprivs-ssl-cert string deprecated: use db_ssl_cert
--db-config-allprivs-ssl-key string deprecated: use db_ssl_key
--db-config-allprivs-uname string deprecated: use db_allprivs_user (default "vt_allprivs")
--db-config-allprivs-unixsocket string deprecated: use db_socket
--db-config-app-charset string deprecated: use db_charset (default "utf8mb4")
--db-config-app-flags uint deprecated: use db_flags
--db-config-app-flavor string deprecated: use db_flavor
--db-config-app-host string deprecated: use db_host
--db-config-app-pass string db app deprecated: use db_app_password
--db-config-app-port int deprecated: use db_port
--db-config-app-server_name string deprecated: use db_server_name
--db-config-app-ssl-ca string deprecated: use db_ssl_ca
--db-config-app-ssl-ca-path string deprecated: use db_ssl_ca_path
--db-config-app-ssl-cert string deprecated: use db_ssl_cert
--db-config-app-ssl-key string deprecated: use db_ssl_key
--db-config-app-uname string deprecated: use db_app_user (default "vt_app")
--db-config-app-unixsocket string deprecated: use db_socket
--db-config-appdebug-charset string deprecated: use db_charset (default "utf8mb4")
--db-config-appdebug-flags uint deprecated: use db_flags
--db-config-appdebug-flavor string deprecated: use db_flavor
--db-config-appdebug-host string deprecated: use db_host
--db-config-appdebug-pass string db appdebug deprecated: use db_appdebug_password
--db-config-appdebug-port int deprecated: use db_port
--db-config-appdebug-server_name string deprecated: use db_server_name
--db-config-appdebug-ssl-ca string deprecated: use db_ssl_ca
--db-config-appdebug-ssl-ca-path string deprecated: use db_ssl_ca_path
--db-config-appdebug-ssl-cert string deprecated: use db_ssl_cert
--db-config-appdebug-ssl-key string deprecated: use db_ssl_key
--db-config-appdebug-uname string deprecated: use db_appdebug_user (default "vt_appdebug")
--db-config-appdebug-unixsocket string deprecated: use db_socket
--db-config-dba-charset string deprecated: use db_charset (default "utf8mb4")
--db-config-dba-flags uint deprecated: use db_flags
--db-config-dba-flavor string deprecated: use db_flavor
--db-config-dba-host string deprecated: use db_host
--db-config-dba-pass string db dba deprecated: use db_dba_password
--db-config-dba-port int deprecated: use db_port
--db-config-dba-server_name string deprecated: use db_server_name
--db-config-dba-ssl-ca string deprecated: use db_ssl_ca
--db-config-dba-ssl-ca-path string deprecated: use db_ssl_ca_path
--db-config-dba-ssl-cert string deprecated: use db_ssl_cert
--db-config-dba-ssl-key string deprecated: use db_ssl_key
--db-config-dba-uname string deprecated: use db_dba_user (default "vt_dba")
--db-config-dba-unixsocket string deprecated: use db_socket
--db-config-erepl-charset string deprecated: use db_charset (default "utf8mb4")
--db-config-erepl-dbname string deprecated: dbname does not need to be explicitly configured
--db-config-erepl-flags uint deprecated: use db_flags
--db-config-erepl-flavor string deprecated: use db_flavor
--db-config-erepl-host string deprecated: use db_host
--db-config-erepl-pass string db erepl deprecated: use db_erepl_password
--db-config-erepl-port int deprecated: use db_port
--db-config-erepl-server_name string deprecated: use db_server_name
--db-config-erepl-ssl-ca string deprecated: use db_ssl_ca
--db-config-erepl-ssl-ca-path string deprecated: use db_ssl_ca_path
--db-config-erepl-ssl-cert string deprecated: use db_ssl_cert
--db-config-erepl-ssl-key string deprecated: use db_ssl_key
--db-config-erepl-uname string deprecated: use db_erepl_user (default "vt_erepl")
--db-config-erepl-unixsocket string deprecated: use db_socket
--db-config-filtered-charset string deprecated: use db_charset (default "utf8mb4")
--db-config-filtered-flags uint deprecated: use db_flags
--db-config-filtered-flavor string deprecated: use db_flavor
--db-config-filtered-host string deprecated: use db_host
--db-config-filtered-pass string db filtered deprecated: use db_filtered_password
--db-config-filtered-port int deprecated: use db_port
--db-config-filtered-server_name string deprecated: use db_server_name
--db-config-filtered-ssl-ca string deprecated: use db_ssl_ca
--db-config-filtered-ssl-ca-path string deprecated: use db_ssl_ca_path
--db-config-filtered-ssl-cert string deprecated: use db_ssl_cert
--db-config-filtered-ssl-key string deprecated: use db_ssl_key
--db-config-filtered-uname string deprecated: use db_filtered_user (default "vt_filtered")
--db-config-filtered-unixsocket string deprecated: use db_socket
--db-config-repl-charset string deprecated: use db_charset (default "utf8mb4")
--db-config-repl-flags uint deprecated: use db_flags
--db-config-repl-flavor string deprecated: use db_flavor
--db-config-repl-host string deprecated: use db_host
--db-config-repl-pass string db repl deprecated: use db_repl_password
--db-config-repl-port int deprecated: use db_port
--db-config-repl-server_name string deprecated: use db_server_name
--db-config-repl-ssl-ca string deprecated: use db_ssl_ca
--db-config-repl-ssl-ca-path string deprecated: use db_ssl_ca_path
--db-config-repl-ssl-cert string deprecated: use db_ssl_cert
--db-config-repl-ssl-key string deprecated: use db_ssl_key
--db-config-repl-uname string deprecated: use db_repl_user (default "vt_repl")
--db-config-repl-unixsocket string deprecated: use db_socket
--db-credentials-file string db credentials file; send SIGHUP to reload this file
--db-credentials-server string db credentials server type ('file' - file implementation; 'vault' - HashiCorp Vault implementation) (default "file")
--db-credentials-vault-addr string URL to Vault server
Expand Down
11 changes: 0 additions & 11 deletions go/flags/endtoend/vtctld.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,6 @@ Usage of vtctld:
--consul_auth_static_file string JSON File to read the topos/tokens from.
--datadog-agent-host string host to send spans to. if empty, no tracing will be done
--datadog-agent-port string port to send spans to. if empty, no tracing will be done
--db-credentials-file string db credentials file; send SIGHUP to reload this file
--db-credentials-server string db credentials server type ('file' - file implementation; 'vault' - HashiCorp Vault implementation) (default "file")
--db-credentials-vault-addr string URL to Vault server
--db-credentials-vault-path string Vault path to credentials JSON blob, e.g.: secret/data/prod/dbcreds
--db-credentials-vault-role-mountpoint string Vault AppRole mountpoint; can also be passed using VAULT_MOUNTPOINT environment variable (default "approle")
--db-credentials-vault-role-secretidfile string Path to file containing Vault AppRole secret_id; can also be passed using VAULT_SECRETID environment variable
--db-credentials-vault-roleid string Vault AppRole id; can also be passed using VAULT_ROLEID environment variable
--db-credentials-vault-timeout duration Timeout for vault API operations (default 10s)
--db-credentials-vault-tls-ca string Path to CA PEM for validating Vault server certificate
--db-credentials-vault-tokenfile string Path to file containing Vault auth token; token can also be passed using VAULT_TOKEN environment variable
--db-credentials-vault-ttl duration How long to cache DB credentials from the Vault server (default 30m0s)
--dba_idle_timeout duration Idle timeout for dba connections (default 1m0s)
--dba_pool_size int Size of the connection pool for dba connections (default 20)
--disable_active_reparents if set, do not allow active reparents. Use this to protect a cluster using external reparents.
Expand Down
Loading