Skip to content

Use Ubuntu 20 for vtgate and tabletmanager workflows#11152

Merged
shlomi-noach merged 1 commit intovitessio:mainfrom
planetscale:fix-ci-gen-script
Sep 1, 2022
Merged

Use Ubuntu 20 for vtgate and tabletmanager workflows#11152
shlomi-noach merged 1 commit intovitessio:mainfrom
planetscale:fix-ci-gen-script

Conversation

@frouioui
Copy link
Copy Markdown
Member

@frouioui frouioui commented Sep 1, 2022

Description

We recently changed the vtgate (#11118) and tablet manager (#11116) CI jobs to run on Ubuntu20, however, the CI generation script did not change. This Pull Request updates the script to generate the same workflows as the ones currently on main.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Sep 1, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@shlomi-noach shlomi-noach added good first issue Good issue for new contributors and removed good first issue Good issue for new contributors labels Sep 1, 2022
@shlomi-noach shlomi-noach merged commit a4f6bfc into vitessio:main Sep 1, 2022
@shlomi-noach shlomi-noach deleted the fix-ci-gen-script branch September 1, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants