Skip to content

Cherrypick to 12.0: VStreamer: recompute table plan if a new table is encountered for the same id (#9978)#11148

Merged
rohit-nayak-ps merged 1 commit intovitessio:release-12.0from
planetscale:bp-12-9978
Aug 31, 2022
Merged

Cherrypick to 12.0: VStreamer: recompute table plan if a new table is encountered for the same id (#9978)#11148
rohit-nayak-ps merged 1 commit intovitessio:release-12.0from
planetscale:bp-12-9978

Conversation

@rohit-nayak-ps
Copy link
Member

Description

Cherry-pick of #9978

  • Recompute the plan for a table if a new table is encountered for the same id

Signed-off-by: Rohit Nayak rohit@planetscale.com

  • Trigger rebuild

Signed-off-by: Rohit Nayak rohit@planetscale.com

  • Trigger rebuild

Signed-off-by: Rohit Nayak rohit@planetscale.com

Related Issue(s)

#9978

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

… same id (vitessio#9978)

* Recompute the plan for a table if a new table is encountered for the same id

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Trigger rebuild

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Trigger rebuild

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps added the Backport This is a backport label Aug 31, 2022
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 31, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@rohit-nayak-ps rohit-nayak-ps changed the title Cherrypick: VStreamer: recompute table plan if a new table is encountered for the same id (#9978) Cherrypick to 12.0: VStreamer: recompute table plan if a new table is encountered for the same id (#9978) Aug 31, 2022
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review August 31, 2022 19:30
@rohit-nayak-ps rohit-nayak-ps merged commit 7949f23 into vitessio:release-12.0 Aug 31, 2022
@rohit-nayak-ps rohit-nayak-ps deleted the bp-12-9978 branch August 31, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants