Skip to content

Delete go/vt/vttime#10995

Merged
deepthi merged 1 commit intovitessio:mainfrom
planetscale:andrew/pflag/vttime
Aug 11, 2022
Merged

Delete go/vt/vttime#10995
deepthi merged 1 commit intovitessio:mainfrom
planetscale:andrew/pflag/vttime

Conversation

@ajm188
Copy link
Copy Markdown
Contributor

@ajm188 ajm188 commented Aug 11, 2022

Description

No one was importing this:

> go list -f '{{ .ImportPath }}| {{ join .Deps " " }} ' ./go/... | awk -F"|" '$2 ~ " vitess.io/vitess/go/vt/vttime " {print $1}' | wc -l
0

Related Issue(s)

Closes #10990.

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

No one was importing this:

```bash
> go list -f '{{ .ImportPath }}| {{ join .Deps " " }} ' ./go/... | awk -F"|" '$2 ~ " vitess.io/vitess/go/vt/vttime " {print $1}' | wc -l
0
```

Closes vitessio#10990.

Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188 ajm188 added Type: Internal Cleanup Component: General Changes throughout the code base labels Aug 11, 2022
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Aug 11, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@ajm188 ajm188 requested a review from deepthi August 11, 2022 13:13
@deepthi deepthi added release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) and removed release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) labels Aug 11, 2022
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always resurrect this if needed, so fine to delete for now.

@deepthi deepthi merged commit af41597 into vitessio:main Aug 11, 2022
@deepthi deepthi deleted the andrew/pflag/vttime branch August 11, 2022 17:15
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Aug 11, 2022

Backups test was fixed in #10670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch flag definitions to be on pflag instead of flag in package go/vt/vttime

2 participants