Reduce Flakiness of ERS/PRS e2e Tests Using Retries With a Timeout

[mattlord]

Description

The ers_prs_heavy workflow has been very flaky in this PR: #10639. Often having to run 4+ times to succeed. I suspect that all of the new DDL executed at tablet init when the VDiff engine opens is causing replication to be slightly slower and thus we're getting this basic error from various individual tests (the ID and specific test differing on the failed runs):

2022-07-17T21:32:58.8852569Z     utils.go:348: 
2022-07-17T21:32:58.8852912Z         	Error Trace:	utils.go:354
2022-07-17T21:32:58.8853472Z         	            				utils.go:348
2022-07-17T21:32:58.8853942Z         	            				utils.go:526
2022-07-17T21:32:58.8854402Z         	            				utils.go:460
2022-07-17T21:32:58.8854875Z         	            				ers_test.go:453
2022-07-17T21:32:58.8855872Z         	Error:      	Expected nil, but got: &mysql.SQLError{Num:1146, State:"42S02", Message:"Table 'vt_ks.vt_insert_test' doesn't exist", Query:"select msg from vt_insert_test where id=20"}

This patch was tested and verified here and it passed on the first try. 🥳 It was then re-tested and re-verified after this minor follow-up and it passed on the first try again. 🥳 🥳

Related Issue(s)

• VDiff2: Auto retry to continue on error #10639

Checklist

• "Backport me!" label has been added if this change should be backported
• Tests were added or are not required
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
• If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
• If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

• There should be at least one unit or end-to-end test.
• The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

• There should be some code comments as to why things are implemented the way they are.

New/Existing features

• Should be documented, either by modifying the existing documentation or creating new documentation.
• New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• vtctl command output order should be stable and awk-able.

[GuptaManan100]

This is great! I had seen this failure a couple of times before too and had this on my TODO list for a while now. Thank you for making this change.